[Buildroot] [git commit] package/tcl: move comment around, to keep proper indentation

[Buildroot] [git commit] package/tcl: move comment around, to keep proper indentation

[Thomas Petazzoni]

commit: http://git.buildroot.net/buildroot/commit/?id=ac371770de69b5ee5f15eed7dd790558b8835d7d
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

In Kconfig, when there is an item (like a comment) between a symbol and
its dependees, then the indentation is not in effect.

Move the symbol to the top of the file to guarantee the indentation in
menuconfig.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/tcl/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/tcl/Config.in b/package/tcl/Config.in
index 63d1b25..f1fa054 100644
--- a/package/tcl/Config.in
+++ b/package/tcl/Config.in
@@ -1,3 +1,7 @@
+comment "tcl needs a toolchain w/ threads, dynamic library"
+	depends on BR2_USE_MMU
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+
 config BR2_PACKAGE_TCL
 	bool "tcl"
 	# fork()
@@ -11,10 +15,6 @@ config BR2_PACKAGE_TCL
 
 	  http://www.tcl.tk
 
-comment "tcl needs a toolchain w/ threads, dynamic library"
-	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-
 if BR2_PACKAGE_TCL
 
 config BR2_PACKAGE_TCL_DEL_ENCODINGS

[Buildroot] [git commit] package/tcl: move comment around, to keep proper indentation

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

> commit: http://git.buildroot.net/buildroot/commit/?id=ac371770de69b5ee5f15eed7dd790558b8835d7d
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

> In Kconfig, when there is an item (like a comment) between a symbol and
> its dependees, then the indentation is not in effect.

> Move the symbol to the top of the file to guarantee the indentation in
> menuconfig.

> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thomas, it seems like you forgot to use the -s option to git am, please
try to remember.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] package/tcl: move comment around, to keep proper indentation

[Thomas Petazzoni]

Peter,

On Wed, 30 Dec 2015 20:10:42 +0100, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> 
> > commit: http://git.buildroot.net/buildroot/commit/?id=ac371770de69b5ee5f15eed7dd790558b8835d7d
> > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> > In Kconfig, when there is an item (like a comment) between a symbol and
> > its dependees, then the indentation is not in effect.
> 
> > Move the symbol to the top of the file to guarantee the indentation in
> > menuconfig.
> 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Thomas, it seems like you forgot to use the -s option to git am, please
> try to remember.

Hum, right. But in fact it is due to the fact that I did not "git am"
such patches. Yann sent them to the list, then immediately marked them
as RFC in Patchwork, so that they were no longer visible in the list of
pending patches in Patchwork.

So, rather than fetching them with patchwork, I simply "git
cherry-pick"ed them from Yann's Git repo. So the process to get those
patches was not the classical one, hence I forgot to add my SoB line.

Otherwise, I use my "git pwam" alias, which automatically adds my SoB
line, so I can't forget it.

That being said, this is not an excuse, so sorry for the mess. But it
explains why those 6 patches didn't have my SoB line.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com