* [Buildroot] [PATCH 1/1] libdvbpsi: new package
@ 2015-12-30 13:30 Pieterjan Camerlynck
2015-12-30 13:51 ` Thomas Petazzoni
2015-12-30 14:45 ` [Buildroot] [v2 1/2] " Pieterjan Camerlynck
0 siblings, 2 replies; 6+ messages in thread
From: Pieterjan Camerlynck @ 2015-12-30 13:30 UTC (permalink / raw)
To: buildroot
libdvbpsi is a library used by vlc for decoding MPEG TS
Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
---
package/Config.in | 1 +
package/libdvbpsi/Config.in | 8 ++++++++
package/libdvbpsi/libdvbpsi.hash | 4 ++++
package/libdvbpsi/libdvbpsi.mk | 15 +++++++++++++++
package/vlc/vlc.mk | 7 +++++++
5 files changed, 35 insertions(+)
create mode 100644 package/libdvbpsi/Config.in
create mode 100644 package/libdvbpsi/libdvbpsi.hash
create mode 100644 package/libdvbpsi/libdvbpsi.mk
diff --git a/package/Config.in b/package/Config.in
index bc6099d..5abd9d8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1015,6 +1015,7 @@ menu "Multimedia"
source "package/libbluray/Config.in"
source "package/libdcadec/Config.in"
source "package/libdvbcsa/Config.in"
+ source "package/libdvbpsi/Config.in"
source "package/libdvbsi/Config.in"
source "package/libdvdnav/Config.in"
source "package/libdvdread/Config.in"
diff --git a/package/libdvbpsi/Config.in b/package/libdvbpsi/Config.in
new file mode 100644
index 0000000..7323466
--- /dev/null
+++ b/package/libdvbpsi/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBDVBPSI
+ bool "libdvbpsi"
+ help
+ libdvbpsi is a simple library designed for decoding and
+ generation of MPEG TS and DVB PSI tables according to standards
+ ISO/IEC 13818 and ITU-T H.222.0.
+
+ http://www.videolan.org/developers/libdvbpsi.html
diff --git a/package/libdvbpsi/libdvbpsi.hash b/package/libdvbpsi/libdvbpsi.hash
new file mode 100644
index 0000000..cf76616
--- /dev/null
+++ b/package/libdvbpsi/libdvbpsi.hash
@@ -0,0 +1,4 @@
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.md5
+md5 2b217039a1299000c39423441f77e76a libdvbpsi-1.3.0.tar.bz2
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.sha256
+sha256 a2fed1d11980662f919bbd1f29e2462719e0f6227e1a531310bd5a706db0a1fe libdvbpsi-1.3.0.tar.bz2
diff --git a/package/libdvbpsi/libdvbpsi.mk b/package/libdvbpsi/libdvbpsi.mk
new file mode 100644
index 0000000..c45ade0
--- /dev/null
+++ b/package/libdvbpsi/libdvbpsi.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libdvbpsi
+#
+################################################################################
+
+LIBDVBPSI_VERSION = 1.3.0
+LIBDVBPSI_SITE = http://download.videolan.org/pub/libdvbpsi/$(LIBDVBPSI_VERSION)
+LIBDVBPSI_SOURCE = libdvbpsi-$(LIBDVBPSI_VERSION).tar.bz2
+LIBDVBPSI_LICENSE = LGPLv2.1+
+LIBDVBPSI_LICENSE_FILES = COPYING
+LIBDVBPSI_AUTORECONF = YES
+LIBDVBPSI_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index ca1f09c..ee21c16 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -179,6 +179,13 @@ else
VLC_CONF_OPTS += --disable-libass
endif
+ifeq ($(BR2_PACKAGE_LIBDVBPSI),y)
+VLC_CONF_OPTS += --enable-dvbpsi
+VLC_DEPENDENCIES += libdvbpsi
+else
+VLC_CONF_OPTS += --disable-dvbpsi
+endif
+
ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
VLC_CONF_OPTS += --enable-libgcrypt
VLC_DEPENDENCIES += libgcrypt
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] libdvbpsi: new package
2015-12-30 13:30 [Buildroot] [PATCH 1/1] libdvbpsi: new package Pieterjan Camerlynck
@ 2015-12-30 13:51 ` Thomas Petazzoni
2015-12-30 14:45 ` [Buildroot] [v2 1/2] " Pieterjan Camerlynck
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-30 13:51 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for this contribution! See some comments below.
On Wed, 30 Dec 2015 14:30:56 +0100, Pieterjan Camerlynck wrote:
> libdvbpsi is a library used by vlc for decoding MPEG TS
>
> Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
> ---
> package/Config.in | 1 +
> package/libdvbpsi/Config.in | 8 ++++++++
> package/libdvbpsi/libdvbpsi.hash | 4 ++++
> package/libdvbpsi/libdvbpsi.mk | 15 +++++++++++++++
> package/vlc/vlc.mk | 7 +++++++
These should be two separate patches:
- One patch adding the libdvbspi package
- One patch adding its use to the vlc package
> diff --git a/package/libdvbpsi/Config.in b/package/libdvbpsi/Config.in
> new file mode 100644
> index 0000000..7323466
> --- /dev/null
> +++ b/package/libdvbpsi/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBDVBPSI
> + bool "libdvbpsi"
No toolchain dependencies on threads, MMU or anything like that? It is
possible indeed, but if you could verify building this library with the
following toolchain configurations, it would be useful:
http://autobuild.buildroot.org/toolchains/configs/bfin-uclinux.config
http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config
http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config
> diff --git a/package/libdvbpsi/libdvbpsi.mk b/package/libdvbpsi/libdvbpsi.mk
> new file mode 100644
> index 0000000..c45ade0
> --- /dev/null
> +++ b/package/libdvbpsi/libdvbpsi.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# libdvbpsi
> +#
> +################################################################################
> +
> +LIBDVBPSI_VERSION = 1.3.0
> +LIBDVBPSI_SITE = http://download.videolan.org/pub/libdvbpsi/$(LIBDVBPSI_VERSION)
> +LIBDVBPSI_SOURCE = libdvbpsi-$(LIBDVBPSI_VERSION).tar.bz2
> +LIBDVBPSI_LICENSE = LGPLv2.1+
> +LIBDVBPSI_LICENSE_FILES = COPYING
> +LIBDVBPSI_AUTORECONF = YES
Why do you need the autoreconf ? There is a pre-generated configure
script in the tarball, so it should be necessary. If it is necessary
for some reason, could you add a comment above this line explaining why?
Other than that, looks good. Could you send an updated version that
takes into account those comments ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [v2 1/2] libdvbpsi: new package
2015-12-30 13:30 [Buildroot] [PATCH 1/1] libdvbpsi: new package Pieterjan Camerlynck
2015-12-30 13:51 ` Thomas Petazzoni
@ 2015-12-30 14:45 ` Pieterjan Camerlynck
2015-12-30 14:45 ` [Buildroot] [v2 2/2] vlc: add support for libdvbpsi Pieterjan Camerlynck
2015-12-30 22:30 ` [Buildroot] [v2 1/2] libdvbpsi: new package Thomas Petazzoni
1 sibling, 2 replies; 6+ messages in thread
From: Pieterjan Camerlynck @ 2015-12-30 14:45 UTC (permalink / raw)
To: buildroot
libdvbpsi is a library used by vlc for decoding MPEG TS
Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
---
Changes v1->v2
- split adding and using libdvbpsi in two separate patches
- add missing dependency on threads
- remove autoreconf
---
package/Config.in | 1 +
package/libdvbpsi/Config.in | 9 +++++++++
package/libdvbpsi/libdvbpsi.hash | 4 ++++
package/libdvbpsi/libdvbpsi.mk | 14 ++++++++++++++
4 files changed, 28 insertions(+)
create mode 100644 package/libdvbpsi/Config.in
create mode 100644 package/libdvbpsi/libdvbpsi.hash
create mode 100644 package/libdvbpsi/libdvbpsi.mk
diff --git a/package/Config.in b/package/Config.in
index cf994b8..0d77292 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1015,6 +1015,7 @@ menu "Multimedia"
source "package/libbluray/Config.in"
source "package/libdcadec/Config.in"
source "package/libdvbcsa/Config.in"
+ source "package/libdvbpsi/Config.in"
source "package/libdvbsi/Config.in"
source "package/libdvdnav/Config.in"
source "package/libdvdread/Config.in"
diff --git a/package/libdvbpsi/Config.in b/package/libdvbpsi/Config.in
new file mode 100644
index 0000000..2a27964
--- /dev/null
+++ b/package/libdvbpsi/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBDVBPSI
+ bool "libdvbpsi"
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ help
+ libdvbpsi is a simple library designed for decoding and
+ generation of MPEG TS and DVB PSI tables according to standards
+ ISO/IEC 13818 and ITU-T H.222.0.
+
+ http://www.videolan.org/developers/libdvbpsi.html
diff --git a/package/libdvbpsi/libdvbpsi.hash b/package/libdvbpsi/libdvbpsi.hash
new file mode 100644
index 0000000..cf76616
--- /dev/null
+++ b/package/libdvbpsi/libdvbpsi.hash
@@ -0,0 +1,4 @@
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.md5
+md5 2b217039a1299000c39423441f77e76a libdvbpsi-1.3.0.tar.bz2
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.sha256
+sha256 a2fed1d11980662f919bbd1f29e2462719e0f6227e1a531310bd5a706db0a1fe libdvbpsi-1.3.0.tar.bz2
diff --git a/package/libdvbpsi/libdvbpsi.mk b/package/libdvbpsi/libdvbpsi.mk
new file mode 100644
index 0000000..218c19e
--- /dev/null
+++ b/package/libdvbpsi/libdvbpsi.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libdvbpsi
+#
+################################################################################
+
+LIBDVBPSI_VERSION = 1.3.0
+LIBDVBPSI_SITE = http://download.videolan.org/pub/libdvbpsi/$(LIBDVBPSI_VERSION)
+LIBDVBPSI_SOURCE = libdvbpsi-$(LIBDVBPSI_VERSION).tar.bz2
+LIBDVBPSI_LICENSE = LGPLv2.1+
+LIBDVBPSI_LICENSE_FILES = COPYING
+LIBDVBPSI_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [v2 2/2] vlc: add support for libdvbpsi
2015-12-30 14:45 ` [Buildroot] [v2 1/2] " Pieterjan Camerlynck
@ 2015-12-30 14:45 ` Pieterjan Camerlynck
2015-12-30 22:30 ` Thomas Petazzoni
2015-12-30 22:30 ` [Buildroot] [v2 1/2] libdvbpsi: new package Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Pieterjan Camerlynck @ 2015-12-30 14:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
---
package/vlc/vlc.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index ca1f09c..ee21c16 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -179,6 +179,13 @@ else
VLC_CONF_OPTS += --disable-libass
endif
+ifeq ($(BR2_PACKAGE_LIBDVBPSI),y)
+VLC_CONF_OPTS += --enable-dvbpsi
+VLC_DEPENDENCIES += libdvbpsi
+else
+VLC_CONF_OPTS += --disable-dvbpsi
+endif
+
ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
VLC_CONF_OPTS += --enable-libgcrypt
VLC_DEPENDENCIES += libgcrypt
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [v2 1/2] libdvbpsi: new package
2015-12-30 14:45 ` [Buildroot] [v2 1/2] " Pieterjan Camerlynck
2015-12-30 14:45 ` [Buildroot] [v2 2/2] vlc: add support for libdvbpsi Pieterjan Camerlynck
@ 2015-12-30 22:30 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-30 22:30 UTC (permalink / raw)
To: buildroot
Dear Pieterjan Camerlynck,
On Wed, 30 Dec 2015 15:45:54 +0100, Pieterjan Camerlynck wrote:
> diff --git a/package/libdvbpsi/Config.in b/package/libdvbpsi/Config.in
> new file mode 100644
> index 0000000..2a27964
> --- /dev/null
> +++ b/package/libdvbpsi/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBDVBPSI
> + bool "libdvbpsi"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + help
> + libdvbpsi is a simple library designed for decoding and
> + generation of MPEG TS and DVB PSI tables according to standards
> + ISO/IEC 13818 and ITU-T H.222.0.
> +
> + http://www.videolan.org/developers/libdvbpsi.html
You forgot the Config.in comment here about the thread dependency.
I've added it and applied your patch. Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [v2 2/2] vlc: add support for libdvbpsi
2015-12-30 14:45 ` [Buildroot] [v2 2/2] vlc: add support for libdvbpsi Pieterjan Camerlynck
@ 2015-12-30 22:30 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-30 22:30 UTC (permalink / raw)
To: buildroot
Dear Pieterjan Camerlynck,
On Wed, 30 Dec 2015 15:45:55 +0100, Pieterjan Camerlynck wrote:
> Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
> ---
> package/vlc/vlc.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-30 22:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 13:30 [Buildroot] [PATCH 1/1] libdvbpsi: new package Pieterjan Camerlynck
2015-12-30 13:51 ` Thomas Petazzoni
2015-12-30 14:45 ` [Buildroot] [v2 1/2] " Pieterjan Camerlynck
2015-12-30 14:45 ` [Buildroot] [v2 2/2] vlc: add support for libdvbpsi Pieterjan Camerlynck
2015-12-30 22:30 ` Thomas Petazzoni
2015-12-30 22:30 ` [Buildroot] [v2 1/2] libdvbpsi: new package Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox