[Buildroot] [RFC PATCH v2 0/4] package/dhcp

[Buildroot] [RFC PATCH v2 0/4] package/dhcp

[Ricardo Martincoski]

Hi Doug,

On Sun, 10 Jan 2016 15:25:05 -0600, Doug Kehn wrote:
> This patch series bumps dhcp package to 4.3.3. I'm doing this as an RFC to get
[snip]

There is a new release for isc-dhcp from yesterday. It's a security update.

https://kb.isc.org/article/AA-01334/0/CVE-2015-8605%3A-UDP-payload-length-not-properly-checked.html
DHCP version 4.1-ESV-R12-P1
DHCP version 4.3.3-P1

IMO we should have a new version of the patch series before committing it.

Regards,
Ricardo

[Buildroot] [RFC PATCH v2 0/4] package/dhcp

[rdkehn at yahoo.com]

Hi Richardo,

On Wed, Jan 13, 2016 at 07:34:28PM -0200, Ricardo Martincoski wrote:
> Hi Doug,
> 
> On Sun, 10 Jan 2016 15:25:05 -0600, Doug Kehn wrote:
> > This patch series bumps dhcp package to 4.3.3. I'm doing this as an RFC to get
> [snip]
> 
> There is a new release for isc-dhcp from yesterday. It's a security update.
> 
> https://kb.isc.org/article/AA-01334/0/CVE-2015-8605%3A-UDP-payload-length-not-properly-checked.html
> DHCP version 4.1-ESV-R12-P1
> DHCP version 4.3.3-P1
> 
> IMO we should have a new version of the patch series before committing it.

Agree, thanks.

Does the series need to retain the RFC tag, or is the handling of
the embedded bind tar-ball acceptable?

Regards,
...doug

[Buildroot] [RFC PATCH v2 0/4] package/dhcp

[Ricardo Martincoski]

Hi Doug,

On Wed, 13 Jan 2016 16:38:27 -0600, Doug Kehn wrote:
[snip]
> Does the series need to retain the RFC tag, or is the handling of
> the embedded bind tar-ball acceptable?
Regarding the tag, I can't say for sure. I am still new to this mailing list.
Maybe someone else can advise?

I found an issue in the bind configuration when using an external toolchain.
BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
BR2_PACKAGE_DHCP=y
BR2_PACKAGE_DHCP_CLIENT=y
I will post a suggestion in the appropriate patch from de series (1/4).

Regards,
Ricardo

[Buildroot] [RFC PATCH v2 0/4] package/dhcp

[Doug Kehn]

This patch series bumps dhcp package to 4.3.3. I'm doing this as an RFC to get
feed back on the handling of the embedded bind tar-ball that now exists within
the dhcp package.

It looks to me that the embedded bind source is only used to build static
libraries for use by the dhcp source. I don't think these libraries are indented
to be used outside the dhcp package.

I built with an arm-buildroot-linux-gnueabihf toolchain and tested dhclient on a
custom TI-AM3352 based board.

Buildroot thread
  http://lists.busybox.net/pipermail/buildroot/2016-January/149079.html
for related information.

I have not yet pushed any patches upstream. I beleive patches
   0002-dhcp-bind-host-gen.patch
   0003-toolchain-ar.patch
are candidates for upstream, agree?

Regards,
...doug

---
Changes v1 -> v2
  - removed DHCP_PRE_BUILD_HOOKS in favor of patch (suggested by Arnout)
---
Doug Kehn (4):
  package/dhcp: bump version to 4.3.3
  package/dhcp: add bind configure options for cross compiling
  package/dhcp: ensure host cc is used for compiling gen
  package/dhcp: remove hard coded ar reference

 package/dhcp/0001-bind-configure.patch     | 19 ++++++++++
 package/dhcp/0002-dhcp-bind-host-gen.patch | 22 ++++++++++++
 package/dhcp/0003-toolchain-ar.patch       | 58 ++++++++++++++++++++++++++++++
 package/dhcp/dhcp.hash                     |  4 +--
 package/dhcp/dhcp.mk                       | 15 +++++++-
 5 files changed, 115 insertions(+), 3 deletions(-)
 create mode 100644 package/dhcp/0001-bind-configure.patch
 create mode 100644 package/dhcp/0002-dhcp-bind-host-gen.patch
 create mode 100644 package/dhcp/0003-toolchain-ar.patch

-- 
2.6.4