Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/canfestival: fix build with musl
Date: Sat, 16 Jan 2016 18:25:18 +0100	[thread overview]
Message-ID: <20160116182518.44e5f9dc@free-electrons.com> (raw)
In-Reply-To: <CA+BsyQ53-OSsdm=DONB9AX_K+y0a8AKnzf1SrRV7ykZVUagjkw@mail.gmail.com>

Brendan, Yann,

On Sat, 22 Aug 2015 23:35:00 +0100, Brendan Heading wrote:
> >> I was going to take this up with the developers as I can't see a good
> >> reason why the behaviour is different for uclibc and non-uclibc
> >> environments, and in any case CLOCK_REALTIME is almost certainly not
> >> what they want. But I haven't had a spare moment to write a test case
> >> to prove that the timer code used in the non-uclibc version would work
> >> just as well under uclibc.
> >
> > That sounds really weird, indeed... :-(
> 
> It feels like they ran into some kind of issue with uclibc and hacked
> together a fix.
> 
> And IME naive coders often make the mistake of using the wrong CLOCK_*
> parameters when doing POSIX time related things ..
> 
> > OK, I'll try to revisit this later. Thanks for the heads up.
> 
> I thought about submitting a patch with another #ifdef __UCLIBC__
> around the function declaration - not ideal, but it at least matches
> what the upstream were trying to do. But I wasn't sure if such an
> approach would pass muster here ?

Any progress with this? can-festival still fails to build in the
autobuilders due to this:

  http://autobuild.buildroot.net/results/5c5a48b050223d5f4f66a3a5ddde12cb17e310d7/

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-01-16 17:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 21:35 [Buildroot] [PATCH] package/canfestival: fix build with musl Yann E. MORIN
2015-08-22 21:38 ` Yann E. MORIN
2015-08-22 21:45   ` Brendan Heading
2015-08-22 22:25     ` Yann E. MORIN
2015-08-22 22:35       ` Brendan Heading
2015-08-25 20:37         ` Peter Korsgaard
2016-01-16 17:25         ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160116182518.44e5f9dc@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox