Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] linux-headers: allow use of headers from kernel "package" selected
Date: Mon, 18 Jan 2016 23:13:43 +0100	[thread overview]
Message-ID: <20160118221343.GD3380@free.fr> (raw)
In-Reply-To: <20160118230345.52b8f054@free-electrons.com>

Thomas, All,

On 2016-01-18 23:03 +0100, Thomas Petazzoni spake thusly:
> On Mon, 18 Jan 2016 22:47:04 +0100, Yann E. MORIN wrote:
> 
> > Yes, it *is* functionally equivalent. It just looks weird that you have
> > to define the kernel version after (as 'as a conseuence of) the headers
> > version, since logically, it is the opposite that one would want.
> > 
> > However, as you said, it would not be very practical to implement that
> > in a user-friendly way:
> >   - on one hand, it seems totally more logical to define the toolchain
> >     options before enblign a kernel,
> >   - on the other hand, the kernel headers version is very dependent on
> >     the running kernel version.
> > 
> > Chicken'n'egg problem... :-(
> > 
> > So, do we agree that we should drop this patch?
> 
> I also don't like the way the patch is implemented, but I think the
> problem raised by this patch is real. Sometimes people have kernel
> sources that contain some custom kernel headers needed for their
> userspace libraries/applications, and we have no mechanism to allow
> them to use their custom kernel source for the linux-headers package,
> which is a bit annoying.

Ah... I just looked, and indeed all we have is an option to manually
specify the version, nad there is no way to use any of the other sources
that we have for the kernel (tarball, git tree...)

Indeed, we do not have the same functionality.

So, what should we do:

  - "duplicate" for the headers the many ways we have to retrieve a
    kernel's source tree?

  - find a better way to implement Karoly's needs?

IIRC, I think I already suggested that we set the version string from
Kconfig, a bit like:

    choice
        bool "headers version"

    [...]

    config BR2_PKG_HEADERS_AS_KERNEL
        bool "like kernel"
        depends on BR2_LINUX_KERNEL

    comment "blabla needs a kernel to be built"
        depends on !BR2_LINUX_KERNEL

    [...]

    endchoice

    config BR2_DEFAULT_KERNEL_HEADERS
        string
        default BR2_LINUX_KERNEL_VERSION if BR2_PKG_HEADERS_AS_KERNEL

Which will avoid having to deal with tricky Makefile code like this
patch does.

(Yes, it is possible to use another Kconfig variable as a default
value.)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-01-18 22:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01 17:17 [Buildroot] [PATCH v4] linux-headers: allow use of headers from kernel "package" selected Karoly Kasza
2015-03-04 22:37 ` Thomas Petazzoni
2015-03-12 14:07   ` Алексей Бродкин
2016-01-09 17:29 ` Yann E. MORIN
2016-01-18  9:21   ` Peter Korsgaard
2016-01-18 21:47     ` Yann E. MORIN
2016-01-18 21:50       ` Peter Korsgaard
2016-01-18 22:03       ` Thomas Petazzoni
2016-01-18 22:13         ` Yann E. MORIN [this message]
2016-01-18 22:21           ` Thomas Petazzoni
2016-01-18 22:21         ` Peter Korsgaard
2016-01-18 22:24           ` Thomas Petazzoni
2016-01-19  8:21             ` Peter Korsgaard
2016-01-19 10:18               ` Thomas Petazzoni
2016-01-19 10:29                 ` Peter Korsgaard
2016-01-19 10:31                   ` Thomas Petazzoni
2016-01-19 10:37                     ` Peter Korsgaard
2016-01-19 17:22                       ` Yann E. MORIN
2016-01-18 17:42   ` Arnout Vandecappelle
2016-01-19  7:25     ` Алексей Бродкин
2016-01-19 20:10 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160118221343.GD3380@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox