From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/80 v1] package/collectd: use 'menuconfig' instead of 'config'+'menu'
Date: Mon, 18 Jan 2016 22:56:59 +0100 [thread overview]
Message-ID: <20160118225659.16e260ac@free-electrons.com> (raw)
In-Reply-To: <015a3c362744fb1f25235088a353f3d3689fd62f.1452983019.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sat, 16 Jan 2016 23:36:57 +0100, Yann E. MORIN wrote:
> Since there were multiple sub-menus, keep their prompts as a comment, to
> properly separate all famillies of plugins.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
It is really a matter of taste, so my opinion is clearly not a strong
one here. But I believe I actually prefer the current solution. With
your solution yes all sub-options are hidden behind a menu. But this
menu is now very long, and I find the "comment" in Kconfig to not be
very nice separators to separate various parts of the menu.
They are even more confusing in that there are "comments" used as
separators, and real "comments" about missing dependencies, causing
confusion.
So I'm not too fan of this one, but if Arnout and you are happy with it
and Peter likes it, that's OK, it's really a minor detail from my point
of view.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-18 21:56 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 22:38 [Buildroot] [PATCH 0/80 v1] pakages: use menuconfig to group sub-options (branch yem/menuconfig) Yann E. MORIN
2016-01-16 22:36 ` [Buildroot] [PATCH 01/80 v1] package/alsa-lib: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
2016-01-18 21:46 ` Thomas Petazzoni
2016-01-16 22:36 ` [Buildroot] [PATCH 02/80 v1] package/alsa-utils: " Yann E. MORIN
2016-01-18 21:47 ` Thomas Petazzoni
2016-01-16 22:36 ` [Buildroot] [PATCH 03/80 v1] package/angularjs: " Yann E. MORIN
2016-01-18 21:47 ` Thomas Petazzoni
2016-01-16 22:36 ` [Buildroot] [PATCH 04/80 v1] package/angularjs: simplify modules selection Yann E. MORIN
2016-01-18 21:48 ` Thomas Petazzoni
2016-01-18 21:57 ` Yann E. MORIN
2016-01-16 22:36 ` [Buildroot] [PATCH 05/80 v1] package/collectd: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
2016-01-18 21:56 ` Thomas Petazzoni [this message]
2016-01-18 22:00 ` Yann E. MORIN
2016-01-18 22:05 ` Thomas Petazzoni
2016-01-18 22:18 ` Yann E. MORIN
2016-01-18 22:27 ` Thomas Petazzoni
2016-01-18 22:40 ` Yann E. MORIN
2016-01-16 22:36 ` [Buildroot] [PATCH 06/80 v1] package/gd: " Yann E. MORIN
2016-01-16 22:36 ` [Buildroot] [PATCH 07/80 v1] package/gpsd: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 08/80 v1] package/jquery: include external plugins from jquery's Config.in Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 09/80 v1] package/libdrm: move tests programs to the bottom Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 10/80 v1] package/libdrm: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 11/80 v1] package/mono: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 12/80 v1] package/ncftp: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 13/80 v1] package/nfs-utils: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 14/80 v1] package/nodejs: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 15/80 v1] package/ola: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 16/80 v1] package/perl: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 17/80 v1] package/php: move list of extensions after interface selection Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 18/80 v1] package/php: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 19/80 v1] package/python: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 20/80 v1] package/python3: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 21/80 v1] package/python{, 3}: move inclusion of external python modules Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 22/80 v1] package/sdl_image: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 23/80 v1] package/tcl: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 24/80 v1] package/tiff: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 25/80 v1] package/udpcast: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 26/80 v1] package/gstreamer: include plugins from gstreamer's real Config.in Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 27/80 v1] package/gstreamer1: include plugins from gstreamer1's " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 28/80 v1] docs/manual: slightly compactify a paragraph Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 29/80 v1] docs/manual: add ordering of kconfig options' attributes Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 30/80 v1] docs/manual: add example about sub-options Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 31/80 v1] docs/manual: use 'menuconfig' when there are more than 5 sub-options Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 32/80 v1] package/boost: use 'menuconfig' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 33/80 v1] package/cairo: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 34/80 v1] package/connman: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 35/80 v1] package/dejavu: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 36/80 v1] package/directfb: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 37/80 v1] package/dnsmasq: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 38/80 v1] package/dovecot: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 39/80 v1] package/dropbear: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 40/80 v1] package/e2fsprogs: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 41/80 v1] package/efl: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 42/80 v1] package/erlang: include Erlang libraries from erlang's Config.in Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 43/80 v1] package/flot: use 'menuconfig' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 44/80 v1] package/gnuradio: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 45/80 v1] package/gnuradio: split long omment Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 46/80 v1] package/google-material-design-icons: use 'menuconfig' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 47/80 v1] package/gstreamer: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 48/80 v1] package/gstreamer1: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 49/80 v1] package/igh-ethercat: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 50/80 v1] package/imlib2: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 51/80 v1] package/ipsec-tools: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 52/80 v1] package/lftp: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 53/80 v1] package/libiio: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 54/80 v1] package/lighttpd: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 55/80 v1] package/linux-firmware: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 56/80 v1] package/lm-sensors: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 57/80 v1] package/lua{, jit}: move inclusion of external libraries/modules Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 58/80 v1] package/mtd: use 'menuconfig' Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 59/80 v1] package/ncurses: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 60/80 v1] package/ndisc6: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 61/80 v1] package/netsnmp: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 62/80 v1] package/ntp: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 63/80 v1] package/openobex: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 64/80 v1] package/openocd: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 65/80 v1] package/poco: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 66/80 v1] package/quagga: " Yann E. MORIN
2016-01-16 22:37 ` [Buildroot] [PATCH 67/80 v1] package/sdl: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 68/80 v1] package/sdl: include SDL external libraries from sdl's Config.in Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 69/80 v1] package/sdl_*: remove redundant dependency Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 70/80 v1] package/squashfs: use 'menuconfig' Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 71/80 v1] package/sqlite: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 72/80 v1] package/transmission: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 73/80 v1] package/valgrind: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 74/80 v1] package/wpa-supplicant: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 75/80 v1] boot/at91bootstrap3: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 76/80 v1] boot/barebox: " Yann E. MORIN
2016-01-19 9:20 ` Yegor Yefremov
2016-01-16 22:38 ` [Buildroot] [PATCH 77/80 v1] boot/grub: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 78/80 v1] boot/mxs-bootlets: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 79/80 v1] boot/uboot: " Yann E. MORIN
2016-01-16 22:38 ` [Buildroot] [PATCH 80/80 v1] boot/at91bootstrap: choices must have a type Yann E. MORIN
2016-01-19 21:24 ` [Buildroot] [PATCH 0/80 v1] pakages: use menuconfig to group sub-options (branch yem/menuconfig) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118225659.16e260ac@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox