Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/alsa-utils: Add util alsaloop
Date: Mon, 18 Jan 2016 23:25:15 +0100	[thread overview]
Message-ID: <20160118232515.3208f274@free-electrons.com> (raw)
In-Reply-To: <87io2q4khh.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Mon, 18 Jan 2016 22:59:38 +0100, Peter Korsgaard wrote:

>  > +ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSALOOP),y)
>  > +ALSA_UTILS_CONF_OPTS += --enable-alsaloop
>  > +ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
>  > +ALSA_UTILS_DEPENDENCIES += libsamplerate
>  > +endif
>  > +else
>  > +ALSA_UTILS_CONF_OPTS += --disable-alsaloop
>  > +endif
> 
> While libsamplerate is today only (optionally) used by alsaloop, this
> might change in the future, so I prefer to move this check outside the
> _UTILS_ALSALOOP conditional.

Agreed.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-01-18 22:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 21:13 [Buildroot] [PATCH v2] package/alsa-utils: Add util alsaloop Bernd Kuhls
2016-01-18 21:59 ` Peter Korsgaard
2016-01-18 22:25   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160118232515.3208f274@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox