Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/alsa-utils: Add util alsaloop
Date: Mon, 18 Jan 2016 22:59:38 +0100	[thread overview]
Message-ID: <87io2q4khh.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1453151639-28753-1-git-send-email-bernd.kuhls@t-online.de> (Bernd Kuhls's message of "Mon, 18 Jan 2016 22:13:59 +0100")

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Add libsamplerate as optional dependency, see
 > alsa-utils-1.1.0/alsaloop/Makefile.am

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 > ---
 > v2: libsamplerate is not a mandatory, but an optional dependency (Thomas)

 >  package/alsa-utils/Config.in     |  3 +++
 >  package/alsa-utils/alsa-utils.mk | 10 ++++++++++
 >  2 files changed, 13 insertions(+)

 > diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
 > index 82f3ad6..9b8e8c0 100644
 > --- a/package/alsa-utils/Config.in
 > +++ b/package/alsa-utils/Config.in
 > @@ -29,6 +29,9 @@ config BR2_PACKAGE_ALSA_UTILS_ALSACTL
 >  	bool "alsactl"
 >  	default y
 
 > +config BR2_PACKAGE_ALSA_UTILS_ALSALOOP
 > +	bool "alsaloop"
 > +
 >  config BR2_PACKAGE_ALSA_UTILS_ALSAMIXER
 >  	bool "alsamixer"
 >  	select BR2_PACKAGE_NCURSES
 > diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
 > index 32822bb..4b3df19 100644
 > --- a/package/alsa-utils/alsa-utils.mk
 > +++ b/package/alsa-utils/alsa-utils.mk
 > @@ -29,6 +29,15 @@ ALSA_UTILS_DEPENDENCIES += gettext
 >  ALSA_UTILS_CONF_ENV += LIBS=-lintl
 >  endif
 
 > +ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSALOOP),y)
 > +ALSA_UTILS_CONF_OPTS += --enable-alsaloop
 > +ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
 > +ALSA_UTILS_DEPENDENCIES += libsamplerate
 > +endif
 > +else
 > +ALSA_UTILS_CONF_OPTS += --disable-alsaloop
 > +endif

While libsamplerate is today only (optionally) used by alsaloop, this
might change in the future, so I prefer to move this check outside the
_UTILS_ALSALOOP conditional.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-01-18 21:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 21:13 [Buildroot] [PATCH v2] package/alsa-utils: Add util alsaloop Bernd Kuhls
2016-01-18 21:59 ` Peter Korsgaard [this message]
2016-01-18 22:25   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io2q4khh.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox