From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 10/10] gst1-imx: bump to version 0.12.0
Date: Mon, 1 Feb 2016 23:27:11 +0100 [thread overview]
Message-ID: <20160201232711.1e2c85a6@free-electrons.com> (raw)
In-Reply-To: <CAAMH-yufkAQV7p50daw=VYTGeM41RvtpYKsZGzRwZ2K_vKVbxQ@mail.gmail.com>
Hello,
On Mon, 1 Feb 2016 22:20:36 +0100, Gary Bisson wrote:
> > So it no longer depends on the GPU stuff ?
>
> No, you can build this package without the GPU backend which implies
> the GPU sinks won't be built. The end goal is for i.MX7 which doesn't
> have any GPU, right now I have to include the GPU binaries just to
> build the pxp/v4l plugins.
ACK, makes sense.
> >> - depends on BR2_PACKAGE_LIBFSLVPUWRAP
> >> select BR2_PACKAGE_GST1_PLUGINS_BASE
> >> + select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
> >> + select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN
> >
> > This is weird. If you "select" these options here, it means that there
> > is no way to disable those options. So why are they options in the
> > first place ?
>
> I just wanted to make it explicit that the package will at least build
> those two plugins. Then leaving it up to the user to select whichever
> plugin he wants. There actually is no option to disable plugins from
> the packages, it's all a question of dependency. As soon as the i.MX
> linux kernel is built, PXP and IPU will be. As soon as the GPU
> libraries are includes, GPU sink plugins will be built.
Hum, then it is not good, because it means that even if you disable the
GPU sink plugin options, but still have the GPU libraries enabled, the
GPU sink plugins will be installed on your target. This is very
confusing.
I think you should remove the sub-options, and then simply expand the
Config.in help text of the main option to say:
- The IPU and PXP plugins are always built.
- The GPU sink plugin is built when ... is enabled.
- The ... plugin is built when ... is enabled.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-01 22:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 11:45 [Buildroot] [PATCH 00/10] Update most Freescale packages Gary Bisson
2016-01-30 11:45 ` [Buildroot] [PATCH 01/10] firmware-imx: bump to version 5.2 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-02-01 20:56 ` Gary Bisson
2016-01-30 11:45 ` [Buildroot] [PATCH 02/10] imx-kobs: bump to version 5.1 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 03/10] imx-lib: " Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 04/10] freescale-imx: remove FREESCALE_IMX_VERSION Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 05/10] libfslcodec: bump to version 4.0.7 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 06/10] libfslparser: " Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 07/10] libfslvpuwrap: bump to version 1.0.61 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 08/10] libimxvpuapi: add new package Gary Bisson
2016-02-01 20:42 ` Thomas Petazzoni
2016-02-01 21:07 ` Gary Bisson
2016-02-01 21:17 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 09/10] gst1-plugins-bad: add install to staging directory Gary Bisson
2016-02-01 20:42 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 10/10] gst1-imx: bump to version 0.12.0 Gary Bisson
2016-02-01 20:44 ` Thomas Petazzoni
2016-02-01 21:20 ` Gary Bisson
2016-02-01 22:27 ` Thomas Petazzoni [this message]
2016-02-01 22:49 ` Gary Bisson
2016-02-02 8:56 ` Arnout Vandecappelle
2016-02-02 9:07 ` Gary Bisson
2016-02-02 8:51 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201232711.1e2c85a6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox