[Buildroot] [PATCH] webkitgtk24: fix building with rpi egl/gles

[Buildroot] [PATCH] webkitgtk24: fix building with rpi egl/gles

[Gustavo Zacarias]

It needs special handling for the additional include fixes. Fixes:
http://autobuild.buildroot.net/results/083/083ce94b1ac61a60aa16906336612af59e32b18b/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/webkitgtk24/webkitgtk24.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/webkitgtk24/webkitgtk24.mk b/package/webkitgtk24/webkitgtk24.mk
index 8a831d9..07927ac 100644
--- a/package/webkitgtk24/webkitgtk24.mk
+++ b/package/webkitgtk24/webkitgtk24.mk
@@ -69,6 +69,13 @@ WEBKITGTK24_CONF_OPTS += \
 	--enable-webgl \
 	--disable-glx
 WEBKITGTK24_DEPENDENCIES += libegl libgles
+# RPi EGL/GLES needs special handling
+ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
+WEBKITGTK24_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) \
+	-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
+        -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
+	LIBS="-lvcos -lvchostif"
+endif
 # No GL
 else
 WEBKITGTK24_CONF_OPTS += \
-- 
2.4.10

[Buildroot] [PATCH] webkitgtk24: fix building with rpi egl/gles

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Mon,  8 Feb 2016 19:52:00 -0300, Gustavo Zacarias wrote:
> It needs special handling for the additional include fixes. Fixes:
> http://autobuild.buildroot.net/results/083/083ce94b1ac61a60aa16906336612af59e32b18b/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/webkitgtk24/webkitgtk24.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/webkitgtk24/webkitgtk24.mk b/package/webkitgtk24/webkitgtk24.mk
> index 8a831d9..07927ac 100644
> --- a/package/webkitgtk24/webkitgtk24.mk
> +++ b/package/webkitgtk24/webkitgtk24.mk
> @@ -69,6 +69,13 @@ WEBKITGTK24_CONF_OPTS += \
>  	--enable-webgl \
>  	--disable-glx
>  WEBKITGTK24_DEPENDENCIES += libegl libgles
> +# RPi EGL/GLES needs special handling
> +ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
> +WEBKITGTK24_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) \
> +	-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
> +        -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
> +	LIBS="-lvcos -lvchostif"
> +endif

Isn't it possible to use pkg-config ? We install egl.pc and glesv2.pc
from all our OpenGL implementations specifically for this reason.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] webkitgtk24: fix building with rpi egl/gles

[Gustavo Zacarias]

On 09/02/16 07:45, Thomas Petazzoni wrote:

> Isn't it possible to use pkg-config ? We install egl.pc and glesv2.pc
> from all our OpenGL implementations specifically for this reason.
>
> Thanks!
>
> Thomas

Hi.
Ehhh sure, though i did find it odd that many others users of these 
don't do it, like kodi, gst-omx, libcec and gst1-plugins-bad.

Care to look at http://patchwork.ozlabs.org/patch/564312/ as well since 
it fixes the other webkitgtk24 build failure? (unknown/dependencies, 
plus it's also nice to save users some crazyness).

http://patchwork.ozlabs.org/patch/564313/ might be nice as well to 
legacy the midori https option since it becomes redundant.

(these two are backports of 2.10.x which doesn't make sense to submit 
until libgtk3 is bumped/wayland fixed).

Regards.