From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] protobuf: apply patch to compile for PowerPC
Date: Wed, 10 Feb 2016 16:57:00 +0100 [thread overview]
Message-ID: <20160210165700.7f97a29c@free-electrons.com> (raw)
In-Reply-To: <927354538.1864929.1455117949486.JavaMail.zimbra@datacom.ind.br>
Dear Carlos Santos,
On Wed, 10 Feb 2016 13:25:49 -0200 (BRST), Carlos Santos wrote:
> > config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
> > bool
> > default y if BR2_arm
> > default y if BR2_i386
> > default y if BR2_mipsel
> > default y if BR2_x86_64
>
> These architecture checks would be superseded by the BR2_TOOLCHAIN_HAS_ATOMIC boolean.
Indeed.
> > default y if BR2_TOOLCHAIN_HAS_ATOMIC
> > depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> >
> > *and* ensure protobuf gets linked with -latomic.
>
> Hum, this requires a patch on configure.ac that that would hardly be accepted upstream.
Why? If they use __atomic_*() built-ins, then they must link with
libatomic if it exists, since __atomic_*() built-ins are not guaranteed
to be available on all architectures if you don't link with libatomic.
Look for example at the Android NDK documentation, which says that you
should link with libatomic when using <atomic> in C++ :
http://developer.android.com/ndk/guides/cpp-support.html
(search for "atomic support").
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-10 15:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 13:08 [Buildroot] [PATCH 1/1] protobuf: apply patch to compile for PowerPC Carlos Santos
2016-02-04 23:06 ` Thomas Petazzoni
2016-02-05 11:04 ` Henrique Marks
2016-02-05 13:09 ` Thomas Petazzoni
2016-02-05 13:22 ` Henrique Marks
2016-02-05 13:37 ` Thomas Petazzoni
2016-02-07 21:19 ` Thomas Petazzoni
2016-02-10 15:25 ` Carlos Santos
2016-02-10 15:57 ` Thomas Petazzoni [this message]
2016-02-10 16:32 ` Carlos Santos
2016-02-10 16:44 ` Thomas Petazzoni
2016-02-10 16:50 ` Carlos Santos
2016-02-10 18:30 ` Carlos Santos
2016-02-10 20:13 ` Thomas Petazzoni
2016-02-11 15:14 ` Carlos Santos
2016-02-10 15:33 ` [Buildroot] [PATCH 1/1] protobuf: fix detection of __atomic_*() built-ins Carlos Santos
2016-02-10 15:50 ` Thomas Petazzoni
2016-02-10 18:42 ` Carlos Santos
2016-02-10 20:06 ` Arnout Vandecappelle
2016-02-10 20:00 ` Arnout Vandecappelle
2016-02-11 14:56 ` Carlos Santos
2016-02-11 15:23 ` Carlos Santos
2016-02-17 17:43 ` [Buildroot] [PATCH v2 0/1] " Carlos Santos
2016-02-17 17:43 ` [Buildroot] [PATCH v2 1/1] " Carlos Santos
2016-02-27 21:55 ` Arnout Vandecappelle
2016-03-20 22:43 ` Thomas Petazzoni
2016-02-17 18:33 ` [Buildroot] [PATCH v2 0/1] " Carlos Santos
2016-02-17 20:51 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210165700.7f97a29c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox