[Buildroot] [PATCH 1/2] package/Makefile.in: append endianness argument to TARGET_LD for MIPS

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Arnout,

On Wed, 17 Feb 2016 23:41:14 +0100, Arnout Vandecappelle wrote:

>  So, are we really going to "fix" all packages that use ld directly? I don't see
> why a package shouldn't be allowed to call ld when it is really doing linking
> without any other toolchainy stuff.

Which isn't the case here. It's linking perf, i.e a normal userspace
application.

But it might indeed be difficult to convince the kernel developers to
change this, except if you have a solid argumentation.

>  LDFLAGS has a bit of the same problem: there will probably be packages that
> don't (completely) honour it.

Yes, and we should fix this IMO.

>  For CFLAGS, that was the reason why we introduced the wrapper. So I think we
> should just add a wrapper for ld as well.

Why not.

>  Unless Vicente volunteers to work on an ld wrapper, I guess on the short term
> we should take patches like these. That said, it should really be passed through
> LDFLAGS and not LD itself.

And the hack be limited to those specific packages that are broken,
IMO. At least until we realize how many packages are affected by this.
It would be annoying to put those additional flags globally just to fix
one single package.

So I would like a patch that touches only the perf build logic for now,
until we see other packages in the same situation.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com