From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/Makefile.in: append endianness argument to TARGET_LD for MIPS
Date: Thu, 18 Feb 2016 14:20:30 +0000 [thread overview]
Message-ID: <56C5D32E.1090002@imgtec.com> (raw)
In-Reply-To: <87si0qwetv.fsf@dell.be.48ers.dk>
Hello Peter, Thomas and Arnout,
so, do you prefer a patch to just fix perf?
The perf Makefile doesn't read an environmental LDFLAGS variable, so
adding -EL/-EB to LDFLAGS will not work.
Also, doing LD="$(TARGET_CC)" in order to use gcc for linking doesn't
work either and it fails with errors about '-lgcc_s' not found.
Are you ok with doing LD="$(TARGET_LD) -EL/-EB" only when building perf
for MIPS architecture?
Regards,
Vincent.
On 18/02/16 09:25, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> Hi,
>
> >> Unless Vicente volunteers to work on an ld wrapper, I guess on the short term
> >> we should take patches like these. That said, it should really be passed through
> >> LDFLAGS and not LD itself.
>
> > And the hack be limited to those specific packages that are broken,
> > IMO. At least until we realize how many packages are affected by this.
> > It would be annoying to put those additional flags globally just to fix
> > one single package.
>
> As I understood it from Vicente on IRC:
>
> - The endian flags are always required when linking
> - The options are understood both when linking with gcc and ld
>
> Which is why I suggested we do it globally.
>
next prev parent reply other threads:[~2016-02-18 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 17:07 [Buildroot] [PATCH 1/2] package/Makefile.in: append endianness argument to TARGET_LD for MIPS Vicente Olivert Riera
2016-02-17 17:07 ` [Buildroot] [PATCH 2/2] linux/linux.mk: add LD="$(TARGET_LD)" to LINUX_MAKE_FLAGS Vicente Olivert Riera
2016-02-17 21:13 ` [Buildroot] [PATCH 1/2] package/Makefile.in: append endianness argument to TARGET_LD for MIPS Thomas Petazzoni
2016-02-17 22:41 ` Arnout Vandecappelle
2016-02-18 8:07 ` Thomas Petazzoni
2016-02-18 9:25 ` Peter Korsgaard
2016-02-18 14:20 ` Vicente Olivert Riera [this message]
2016-02-18 14:44 ` Peter Korsgaard
2016-02-20 9:34 ` Jan Heylen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C5D32E.1090002@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox