[Buildroot] [PATCH v2 1/2] package/libarchive: add optional support for bzip2

[Buildroot] [PATCH v2 1/2] package/libarchive: add optional support for bzip2

[Bernd Kuhls]

When bzip2 was compiled before, libarchive will use it as optional
dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libarchive.so.13.1.2 | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libbz2.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]

configure.ac always checks bz2 support unless --without-bz2lib is used:
https://github.com/libarchive/libarchive/blob/master/configure.ac#L300

Therefore we do not need --with-bz2lib.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: Added note why --with-bz2lib is not needed (Arnout)

 package/libarchive/libarchive.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index 206de3f..f438d6e 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -42,6 +42,12 @@ else
 LIBARCHIVE_CONF_OPTS += --disable-xattr
 endif
 
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+LIBARCHIVE_DEPENDENCIES += bzip2
+else
+LIBARCHIVE_CONF_OPTS += --without-bz2lib
+endif
+
 ifeq ($(BR2_PACKAGE_EXPAT),y)
 LIBARCHIVE_DEPENDENCIES += expat
 else
-- 
2.7.0

[Buildroot] [PATCH v2 2/2] package/libarchive: Remove unneeded CONF_OPTS for xz support

[Bernd Kuhls]

configure.ac always checks xz support unless --without-lzma is used:
https://github.com/libarchive/libarchive/blob/master/configure.ac#L365

Having --with-lzma is therefore useless.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: First revision

 package/libarchive/libarchive.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index f438d6e..e0a10fb 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -93,7 +93,6 @@ endif
 
 ifeq ($(BR2_PACKAGE_XZ),y)
 LIBARCHIVE_DEPENDENCIES += xz
-LIBARCHIVE_CONF_OPTS += --with-lzma
 else
 LIBARCHIVE_CONF_OPTS += --without-lzma
 endif
-- 
2.7.0

[Buildroot] [PATCH v2 1/2] package/libarchive: add optional support for bzip2

[Thomas Petazzoni]

Bernd,

On Sat, 20 Feb 2016 14:53:54 +0100, Bernd Kuhls wrote:

> configure.ac always checks bz2 support unless --without-bz2lib is used:
> https://github.com/libarchive/libarchive/blob/master/configure.ac#L300
> 
> Therefore we do not need --with-bz2lib.

Still, we prefer to be explicit, and pass --with-<foo> for all
AC_ARG_WITH() options.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com