Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace
@ 2016-02-20 23:12 Bernd Kuhls
  2016-02-20 23:12 ` [Buildroot] [PATCH 1/1] package/quota: add optional support for e2fsprogs Bernd Kuhls
  2016-02-21 13:43 ` [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2016-02-20 23:12 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/e2fsprogs/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/e2fsprogs/Config.in b/package/e2fsprogs/Config.in
index ac3eae7..e540337 100644
--- a/package/e2fsprogs/Config.in
+++ b/package/e2fsprogs/Config.in
@@ -1,4 +1,3 @@
-
 config BR2_PACKAGE_E2FSPROGS
 	bool "e2fsprogs"
 	depends on BR2_USE_WCHAR # util-linux
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/quota: add optional support for e2fsprogs
  2016-02-20 23:12 [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace Bernd Kuhls
@ 2016-02-20 23:12 ` Bernd Kuhls
  2016-02-21 13:43   ` Thomas Petazzoni
  2016-02-21 13:43 ` [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace Thomas Petazzoni
  1 sibling, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2016-02-20 23:12 UTC (permalink / raw)
  To: buildroot

When e2fsprogs was compiled before, quota will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/quotacheck | grep NEEDED | sort
 0x0000000000000001 (NEEDED)             Shared library: [libcom_err.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libext2fs.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libintl.so.8]

Quote from configure log before this patch when e2fsprogs were missing:

checking ext2fs/ext2fs.h usability... no
checking ext2fs/ext2fs.h presence... no
checking for ext2fs/ext2fs.h... no
checking for com_err in -lcom_err... no
checking for ext2fs_initialize in -lext2fs... no
configure: WARNING: Ext2 direct support won't be compiled. Libraries not found.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/quota/quota.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/quota/quota.mk b/package/quota/quota.mk
index a6b0322..c30a2bd 100644
--- a/package/quota/quota.mk
+++ b/package/quota/quota.mk
@@ -18,6 +18,13 @@ QUOTA_DEPENDENCIES += gettext
 QUOTA_LIBS += -lintl
 endif
 
+ifeq ($(BR2_PACKAGE_E2FSPROGS),y)
+QUOTA_DEPENDENCIES += e2fsprogs
+QUOTA_CONF_OPTS += --enable-ext2direct
+else
+QUOTA_CONF_OPTS += --disable-ext2direct
+endif
+
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 QUOTA_DEPENDENCIES += libtirpc host-pkgconf
 QUOTA_CFLAGS += `$(PKG_CONFIG_HOST_BINARY) --cflags libtirpc`
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace
  2016-02-20 23:12 [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace Bernd Kuhls
  2016-02-20 23:12 ` [Buildroot] [PATCH 1/1] package/quota: add optional support for e2fsprogs Bernd Kuhls
@ 2016-02-21 13:43 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-02-21 13:43 UTC (permalink / raw)
  To: buildroot

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 00:12:04 +0100, Bernd Kuhls wrote:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/e2fsprogs/Config.in | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/quota: add optional support for e2fsprogs
  2016-02-20 23:12 ` [Buildroot] [PATCH 1/1] package/quota: add optional support for e2fsprogs Bernd Kuhls
@ 2016-02-21 13:43   ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-02-21 13:43 UTC (permalink / raw)
  To: buildroot

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 00:12:05 +0100, Bernd Kuhls wrote:
> When e2fsprogs was compiled before, quota will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/quotacheck | grep NEEDED | sort
>  0x0000000000000001 (NEEDED)             Shared library: [libcom_err.so.2]
>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]
>  0x0000000000000001 (NEEDED)             Shared library: [libext2fs.so.2]
>  0x0000000000000001 (NEEDED)             Shared library: [libintl.so.8]
> 
> Quote from configure log before this patch when e2fsprogs were missing:
> 
> checking ext2fs/ext2fs.h usability... no
> checking ext2fs/ext2fs.h presence... no
> checking for ext2fs/ext2fs.h... no
> checking for com_err in -lcom_err... no
> checking for ext2fs_initialize in -lext2fs... no
> configure: WARNING: Ext2 direct support won't be compiled. Libraries not found.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/quota/quota.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-21 13:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 23:12 [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace Bernd Kuhls
2016-02-20 23:12 ` [Buildroot] [PATCH 1/1] package/quota: add optional support for e2fsprogs Bernd Kuhls
2016-02-21 13:43   ` Thomas Petazzoni
2016-02-21 13:43 ` [Buildroot] [PATCH 1/1] package/e2fsprogs: remove whitespace Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox