From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap
Date: Sun, 21 Feb 2016 18:23:36 +0100 [thread overview]
Message-ID: <20160221182336.20b8066c@free-electrons.com> (raw)
In-Reply-To: <1456066125-28379-1-git-send-email-bernd.kuhls@t-online.de>
Bernd,
On Sun, 21 Feb 2016 15:48:39 +0100, Bernd Kuhls wrote:
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=capabilities
> +GSTREAMER1_DEPENDENCIES += libcap
> +else
> +GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=auto
> +endif
I am not entirely sure about this one. When BR2_PACKAGE_LIBCAP=y, are
we sure that the user wants to use capabilities for everything
including this GStreamer feature? There are other possible values for
--with-ptp-helper-permissions. So it would be good to have a commit log
that details a bit more the reasoning, other than just "it might use
libcap, so let's use it".
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-02-21 17:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 14:48 [Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap Bernd Kuhls
2016-02-21 14:48 ` [Buildroot] [PATCH 2/7] package/gstreamer1/gst1-plugins-good: add optional support for libv4l Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 3/7] package/chrony: add optional support for libcap Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 4/7] package/kismet: " Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 5/7] package/nfs-utils: " Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 6/7] package/avahi: " Bernd Kuhls
2016-02-21 17:25 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 7/7] package/quagga: " Bernd Kuhls
2016-02-21 17:26 ` Thomas Petazzoni
2016-02-21 17:23 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221182336.20b8066c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox