From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/7] package/avahi: add optional support for libcap
Date: Sun, 21 Feb 2016 18:25:15 +0100 [thread overview]
Message-ID: <20160221182515.4f082234@free-electrons.com> (raw)
In-Reply-To: <1456066125-28379-6-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sun, 21 Feb 2016 15:48:44 +0100, Bernd Kuhls wrote:
> diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
> index 5d6e6a8..ce89e42 100644
> --- a/package/avahi/avahi.mk
> +++ b/package/avahi/avahi.mk
> @@ -117,6 +117,9 @@ endif
>
> ifeq ($(BR2_PACKAGE_AVAHI_DAEMON),y)
> AVAHI_DEPENDENCIES += expat
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +AVAHI_DEPENDENCIES += libcap
> +endif
It is a bit weird to have this in the middle of the expat handling, IMO.
> AVAHI_CONF_OPTS += --with-xml=expat
> else
> AVAHI_CONF_OPTS += --with-xml=none
Shouldn't we simply do:
ifeq ($(BR2_PACKAGE_EXPAT),y)
AVAHI_DEPENDENCIES += expat
AVAHI_CONF_OPTS += --with-xml=expat
else
AVAHI_CONF_OPTS += --with-xml=none
endif
ifeq ($(BR2_PACKAGE_LIBCAP),y)
AVAHI_DEPENDENCIES += libcap
endif
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-21 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 14:48 [Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap Bernd Kuhls
2016-02-21 14:48 ` [Buildroot] [PATCH 2/7] package/gstreamer1/gst1-plugins-good: add optional support for libv4l Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 3/7] package/chrony: add optional support for libcap Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 4/7] package/kismet: " Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 5/7] package/nfs-utils: " Bernd Kuhls
2016-02-21 17:23 ` Thomas Petazzoni
2016-02-21 14:48 ` [Buildroot] [PATCH 6/7] package/avahi: " Bernd Kuhls
2016-02-21 17:25 ` Thomas Petazzoni [this message]
2016-02-21 14:48 ` [Buildroot] [PATCH 7/7] package/quagga: " Bernd Kuhls
2016-02-21 17:26 ` Thomas Petazzoni
2016-02-21 17:23 ` [Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221182515.4f082234@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox