From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/spice: depend on libglib2
Date: Sun, 21 Feb 2016 21:12:49 +0100 [thread overview]
Message-ID: <20160221211249.723daeb6@free-electrons.com> (raw)
In-Reply-To: <1456076407-20364-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sun, 21 Feb 2016 18:40:07 +0100, Bernd Kuhls wrote:
> The package selects BR2_PACKAGE_LIBGLIB2 but did not depend on it.
>
> The buildsystem treats libglib2 as a hard-dependency:
> https://cgit.freedesktop.org/spice/spice/tree/configure.ac?h=0.12#n117
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
I am not sure in fact. The part of configure.ac you're pointing to
simply adds libglib2 to SPICE_REQUIRES, which is *only* used in the
spice build system to fill in the Requires.private field of
spice-server.pc. I.e, it seems like libglib2 is only an indirect
dependency of spice, and a reference to libglib2 only needed when
static linking.
This clearly needs more investigation, as other dependencies of spice
are handled in the same way.
Yann, you originally added the spice package, maybe you can have a look?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-21 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 17:40 [Buildroot] [PATCH 1/1] package/spice: depend on libglib2 Bernd Kuhls
2016-02-21 20:12 ` Thomas Petazzoni [this message]
2016-02-21 22:05 ` Yann E. MORIN
2016-02-21 22:10 ` Thomas Petazzoni
2016-02-21 22:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221211249.723daeb6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox