From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/spice: depend on libglib2
Date: Sun, 21 Feb 2016 23:10:59 +0100 [thread overview]
Message-ID: <20160221231059.4491f666@free-electrons.com> (raw)
In-Reply-To: <20160221220552.GF3456@free.fr>
Yann,
On Sun, 21 Feb 2016 23:05:52 +0100, Yann E. MORIN wrote:
> $ git grep -E '\<glib.h\>'
> server/reds.c:#include <glib.h>
>
> The server is not optional (only the client is), and reds.c is not
> conditoinal in server/Makefile.am.
Aaah, I missed the PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.22]) line.
Since I believe Bernd's patch was pointing to:
SPICE_REQUIRES+=" glib-2.0 >= 2.22"
I thought he was referring to this line as the justification for the
glib dependency.
But OK, it really needs glib. I'll apply Bernd's patch. Thanks for
confirming!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-21 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 17:40 [Buildroot] [PATCH 1/1] package/spice: depend on libglib2 Bernd Kuhls
2016-02-21 20:12 ` Thomas Petazzoni
2016-02-21 22:05 ` Yann E. MORIN
2016-02-21 22:10 ` Thomas Petazzoni [this message]
2016-02-21 22:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221231059.4491f666@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox