From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/avahi: add optional support for libcap
Date: Sun, 21 Feb 2016 22:46:26 +0100 [thread overview]
Message-ID: <20160221214626.GE3456@free.fr> (raw)
In-Reply-To: <87y4adaj6z.fsf@dell.be.48ers.dk>
Bernd, Thomas, Peter, All,
On 2016-02-21 21:43 +0100, Peter Korsgaard spake thusly:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> > Dear Bernd Kuhls,
> > On Sun, 21 Feb 2016 18:57:19 +0100, Bernd Kuhls wrote:
> >> When libcap was compiled before, avahi daemon will use it as optional
> >> dependency:
> >>
> >> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/avahi-daemon | grep NEEDED | sort
> >> 0x0000000000000001 (NEEDED) Shared library: [libavahi-common.so.3]
> >> 0x0000000000000001 (NEEDED) Shared library: [libavahi-core.so.7]
> >> 0x0000000000000001 (NEEDED) Shared library: [libcap.so.2]
> >> [...]
> >>
> >> The build system offers no option to en-/disable libcap support:
> >> http://git.0pointer.net/avahi.git/tree/configure.ac#n382
> >>
> >> The check for libcap was placed inside the BR2_PACKAGE_AVAHI_DAEMON
> >> because only avahi-daemon uses libcap, it provides chroot support.
>
> > Still, the configure.ac test is done unconditionally (i.e regardless
> > of whether the daemon is enabled or not), so I believe we should also
> > do the same.
>
> > Peter, Yann, Arnout, your thoughts?
>
> It's safer to do it unconditionally (and we are unlikely to have
> problems with dependency loops with avahi/libcap, so that's not an issue
> either).
>
> So I would prefer to have it outside the _DAEMON conditional as well.
Yes, agreed.
With a comment explaining so, of course.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-02-21 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 17:57 [Buildroot] [PATCH v2 1/1] package/avahi: add optional support for libcap Bernd Kuhls
2016-02-21 20:35 ` Thomas Petazzoni
2016-02-21 20:43 ` Peter Korsgaard
2016-02-21 21:46 ` Yann E. MORIN [this message]
2016-02-25 22:12 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221214626.GE3456@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox