Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/avahi: add optional support for libcap
Date: Thu, 25 Feb 2016 23:12:17 +0100	[thread overview]
Message-ID: <20160225231217.56780d72@free-electrons.com> (raw)
In-Reply-To: <1456077439-26606-1-git-send-email-bernd.kuhls@t-online.de>

Bernd,

On Sun, 21 Feb 2016 18:57:19 +0100, Bernd Kuhls wrote:
> When libcap was compiled before, avahi daemon will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/avahi-daemon | grep NEEDED | sort
>  0x0000000000000001 (NEEDED)             Shared library: [libavahi-common.so.3]
>  0x0000000000000001 (NEEDED)             Shared library: [libavahi-core.so.7]
>  0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
> [...]
> 
> The build system offers no option to en-/disable libcap support:
> http://git.0pointer.net/avahi.git/tree/configure.ac#n382
> 
> The check for libcap was placed inside the BR2_PACKAGE_AVAHI_DAEMON
> because only avahi-daemon uses libcap, it provides chroot support.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: moved the new code block a bit and added more notes about the usage
>     of libcap (Thomas)

I've changed the patch to have the libcap condition outside of the
avahi daemon condition, as discussed during the review, and applied to
master.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-02-25 22:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 17:57 [Buildroot] [PATCH v2 1/1] package/avahi: add optional support for libcap Bernd Kuhls
2016-02-21 20:35 ` Thomas Petazzoni
2016-02-21 20:43   ` Peter Korsgaard
2016-02-21 21:46     ` Yann E. MORIN
2016-02-25 22:12 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225231217.56780d72@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox