From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Added OK/FAIL output to SNMP init script.
Date: Thu, 25 Feb 2016 10:46:43 +0100 [thread overview]
Message-ID: <20160225104643.0921463c@free-electrons.com> (raw)
In-Reply-To: <1456335081-4834-1-git-send-email-universeII@gmx.de>
Dear Andreas Ehmanns,
On Wed, 24 Feb 2016 18:31:21 +0100, Andreas Ehmanns wrote:
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> ---
> package/netsnmp/S59snmpd | 98 +++++++++++++++++++++++++++---------------------
> 1 file changed, 56 insertions(+), 42 deletions(-)
While your patch looks OK, it is doing *much* more than "adding
OK/FAIL" as your commit title indicates.
Ideally, you should separate your changes into multiple patches to make
it easier to review the changes (like one patch to change to use
functions, one patch to add OK/FAIL, one patch to remove set -e, etc.).
Or at least, write a commit log that details all the changes that are
being done.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-25 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 17:31 [Buildroot] [PATCH 1/1] Added OK/FAIL output to SNMP init script Andreas Ehmanns
2016-02-25 9:46 ` Thomas Petazzoni [this message]
2016-02-25 20:02 ` Andreas Ehmanns
2016-02-25 20:25 ` Thomas Petazzoni
2016-02-25 20:43 ` Andreas Ehmanns
2016-02-25 21:04 ` Thomas Petazzoni
2016-02-25 21:05 ` Andreas Ehmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225104643.0921463c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox