Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] Add package go-bootstrap
Date: Wed, 2 Mar 2016 23:43:49 +0100	[thread overview]
Message-ID: <20160302234349.7448884e@free-electrons.com> (raw)
In-Reply-To: <a316e4d5ff70594e8f4cccbb819ebf6d9a32e958.1456946494.git.geoff@infradead.org>

Geoff,

The commit title should be:

	go-bootstrap: new host package

On Wed, 02 Mar 2016 19:23:33 +0000, Geoff Levand wrote:

> diff --git a/package/Config.in.host b/package/Config.in.host
> index 1c691a3..7cacef9 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -13,6 +13,7 @@ menu "Host utilities"
>  	source "package/genext2fs/Config.in.host"
>  	source "package/genimage/Config.in.host"
>  	source "package/genpart/Config.in.host"
> +	source "package/go-bootstrap/Config.in.host"

There is no need for a Config.in.host file for this package, it is
just a build dependency for the go compiler, it doesn't need to be
exposed in menuconfig.

> diff --git a/package/go-bootstrap/Config.in.host b/package/go-bootstrap/Config.in.host
> new file mode 100644
> index 0000000..99cca79
> --- /dev/null
> +++ b/package/go-bootstrap/Config.in.host
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_HOST_GO_BOOTSTRAP
> +	bool
> +	help
> +	  Bootstrap compiler needed to build go1.5 and later versions.
> +
> +	  https://golang.org

So, this is not needed.

> diff --git a/package/go-bootstrap/go-bootstrap.mk b/package/go-bootstrap/go-bootstrap.mk
> new file mode 100644
> index 0000000..464f95e
> --- /dev/null
> +++ b/package/go-bootstrap/go-bootstrap.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# go-bootstrap
> +#
> +################################################################################
> +
> +GO_BOOTSTRAP_VERSION = 1.4.2
> +GO_BOOTSTRAP_SITE = https://storage.googleapis.com/golang
> +GO_BOOTSTRAP_SOURCE = go$(GO_BOOTSTRAP_VERSION).src.tar.gz

Will Go 1.4.x always be capable of building newer Go compilers ?

> +
> +GO_BOOTSTRAP_LICENSE = BSD-3c
> +GO_BOOTSTRAP_LICENSE_FILES = LICENSE
> +
> +GO_BOOTSTRAP_FINAL = $(HOST_DIR)/usr/lib/go-$(GO_BOOTSTRAP_VERSION)
> +
> +GO_BOOTSTRAP_MAKE_ENV = \
> +	GOOS=linux \
> +	GOROOT_FINAL="$(GO_BOOTSTRAP_FINAL)" \
> +	GOROOT="$(@D)" \
> +	GOBIN="$(@D)/bin"
> +
> +define HOST_GO_BOOTSTRAP_BUILD_CMDS
> +	cd $(@D)/src && $(GO_BOOTSTRAP_MAKE_ENV) ./make.bash
> +endef
> +
> +define HOST_GO_BOOTSTRAP_INSTALL_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/bin/go $(GO_BOOTSTRAP_FINAL)/bin/go
> +	$(INSTALL) -D -m 0755 $(@D)/bin/gofmt $(GO_BOOTSTRAP_FINAL)/bin/gofmt
> +
> +	cp -a $(@D)/lib $(GO_BOOTSTRAP_FINAL)/
> +	cp -a $(@D)/src $(GO_BOOTSTRAP_FINAL)/

Is it normal to copy source code to HOST_DIR ?

> +	cp -a $(@D)/pkg $(GO_BOOTSTRAP_FINAL)/
> +	chmod -R +x $(GO_BOOTSTRAP_FINAL)/pkg/tool

Why aren't those tools already installed +x by the build process ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-03-02 22:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 19:23 [Buildroot] [PATCH 0/4] Add go language support Geoff Levand
2016-03-02 19:23 ` [Buildroot] [PATCH 3/4] Add go target support Geoff Levand
2016-03-02 22:51   ` Thomas Petazzoni
2016-03-03  1:11     ` Geoff Levand
2016-03-02 19:23 ` [Buildroot] [PATCH 2/4] Add go host support Geoff Levand
2016-03-02 22:50   ` Thomas Petazzoni
2016-03-03  1:11     ` Geoff Levand
2016-03-02 19:23 ` [Buildroot] [PATCH 1/4] Add package go-bootstrap Geoff Levand
2016-03-02 22:43   ` Thomas Petazzoni [this message]
2016-03-03  1:11     ` Geoff Levand
2016-03-03  8:15       ` Thomas Petazzoni
2016-03-02 19:23 ` [Buildroot] [PATCH 4/4] Add package flannel Geoff Levand
2016-03-02 22:53   ` Thomas Petazzoni
2016-03-03  1:11     ` Geoff Levand
2016-03-02 20:49 ` [Buildroot] [PATCH 0/4] Add go language support Thomas Petazzoni
2016-03-02 21:47   ` Geoff Levand
2016-03-02 21:52     ` Christian Stewart
2016-03-02 22:31       ` Geoff Levand
2016-03-02 22:40         ` Christian Stewart
2016-03-21 16:32           ` Geoff Levand
2016-03-22 18:09             ` Christian Stewart
2016-03-02 22:18     ` Thomas Petazzoni
2016-03-02 22:43       ` Geoff Levand
2016-03-02 22:54         ` Thomas Petazzoni
2016-03-03  1:09           ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302234349.7448884e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox