Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] Add package flannel
Date: Wed, 2 Mar 2016 23:53:02 +0100	[thread overview]
Message-ID: <20160302235302.198db5d7@free-electrons.com> (raw)
In-Reply-To: <1572d192abce3a19798cdfe75f3aef8f9e3e504c.1456946494.git.geoff@infradead.org>

Dear Geoff Levand,

The commit title should be:

	flannel: new package

On Wed, 02 Mar 2016 19:23:33 +0000, Geoff Levand wrote:

> diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash
> new file mode 100644
> index 0000000..7459298
> --- /dev/null
> +++ b/package/flannel/flannel.hash
> @@ -0,0 +1,3 @@
> +# Locally computed:
> +sha256 c09a76e80647282687b8db36f28dd3aede650f8f71dad0cf9f453f2ae3a0635d flannel-v0.5.5.tar.gz
> +

Unneeded empty new line.

> +FLANNEL_VERSION = v0.5.5
> +FLANNEL_SITE = https://github.com/coreos/flannel.git
> +FLANNEL_SITE_METHOD = git

Please use the github helper function.

> +
> +FLANNEL_LICENSE = Apache-2.0
> +FLANNEL_LICENSE_FILES = LICENSE
> +
> +FLANNEL_DEPENDENCIES = host-go
> +
> +FLANNEL_MAKE_ENV = \
> +	GOBIN="$(@D)/bin" \
> +	GOPATH="$(@D)/gopath" \
> +	GOARCH=$(GO_GOARCH) \
> +	CGO_ENABLED=1
> +
> +define FLANNEL_CONFIGURE_CMDS
> +	mkdir -p $(@D)/gopath/src/github.com/coreos
> +	ln -s $(@D) $(@D)/gopath/src/github.com/coreos/flannel

This probably warrants a comment above to explain why this is needed.

> +endef
> +
> +define FLANNEL_BUILD_CMDS
> +	cd $(@D) && $(FLANNEL_MAKE_ENV) $(HOST_DIR)/usr/bin/go \
> +		build -v -o $(@D)/bin/flanneld .
> +endef
> +
> +define FLANNEL_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/bin/flanneld $(TARGET_DIR)/opt/bin/flanneld
> +	$(INSTALL) -D -m 0755 $(@D)/dist/mk-docker-opts.sh $(TARGET_DIR)/opt/bin/mk-docker-opts.sh
> +endef
> +
> +$(eval $(generic-package))

Other than that, looks good to me.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-03-02 22:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 19:23 [Buildroot] [PATCH 0/4] Add go language support Geoff Levand
2016-03-02 19:23 ` [Buildroot] [PATCH 1/4] Add package go-bootstrap Geoff Levand
2016-03-02 22:43   ` Thomas Petazzoni
2016-03-03  1:11     ` Geoff Levand
2016-03-03  8:15       ` Thomas Petazzoni
2016-03-02 19:23 ` [Buildroot] [PATCH 2/4] Add go host support Geoff Levand
2016-03-02 22:50   ` Thomas Petazzoni
2016-03-03  1:11     ` Geoff Levand
2016-03-02 19:23 ` [Buildroot] [PATCH 4/4] Add package flannel Geoff Levand
2016-03-02 22:53   ` Thomas Petazzoni [this message]
2016-03-03  1:11     ` Geoff Levand
2016-03-02 19:23 ` [Buildroot] [PATCH 3/4] Add go target support Geoff Levand
2016-03-02 22:51   ` Thomas Petazzoni
2016-03-03  1:11     ` Geoff Levand
2016-03-02 20:49 ` [Buildroot] [PATCH 0/4] Add go language support Thomas Petazzoni
2016-03-02 21:47   ` Geoff Levand
2016-03-02 21:52     ` Christian Stewart
2016-03-02 22:31       ` Geoff Levand
2016-03-02 22:40         ` Christian Stewart
2016-03-21 16:32           ` Geoff Levand
2016-03-22 18:09             ` Christian Stewart
2016-03-02 22:18     ` Thomas Petazzoni
2016-03-02 22:43       ` Geoff Levand
2016-03-02 22:54         ` Thomas Petazzoni
2016-03-03  1:09           ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302235302.198db5d7@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox