From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] legal-info: remove outdated comment
Date: Sun, 6 Mar 2016 11:19:14 +0100 [thread overview]
Message-ID: <20160306101914.GB3501@free.fr> (raw)
In-Reply-To: <1457134753-28197-2-git-send-email-luca@lucaceresoli.net>
Luca, All,
On 2016-03-05 00:39 +0100, Luca Ceresoli spake thusly:
> This comment is outdated since the assignment of $(2)_MANIFEST_TARBALL
> and $(2)_MANIFEST_SITE have been removed, which happened in
> b9f4727ff4d512868352494f5209fff4da147473.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/pkg-generic.mk | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 9ea2a707baa4..189ccf8c8415 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -754,8 +754,7 @@ $(1)-legal-info: $(1)-patch
> endif
>
> # We only save the sources of packages we want to redistribute, that are
> -# non-local, and non-overriden. So only store, in the manifest, the tarball
> -# name of those packages.
> +# non-local, and non-overriden.
I wondered why you kept 'local' here, but then I remembered that we
handle 'local' packages as if they were overriden. I think that's
inherently bad that we do that, but this is not the purpose of your
patch.
Still, I would prefer something like:
... that are non-overriden (local or true override).
otherwise:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
BTW, you're not making my life easy: I'll have to rebase my own legal
series over that, and I expect quite a bunch of conflicts! ;-)
Regards,
Yann E. MORIN.
> ifeq ($$($(2)_REDISTRIBUTE),YES)
> ifeq ($$($(2)_OVERRIDE_SRCDIR),)
> # Packages that have a tarball need it downloaded beforehand
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-03-06 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 23:39 [Buildroot] [PATCH 1/2] legal-info: fix detection of "override" packages Luca Ceresoli
2016-03-04 23:39 ` [Buildroot] [PATCH 2/2] legal-info: remove outdated comment Luca Ceresoli
2016-03-06 10:19 ` Yann E. MORIN [this message]
2016-03-06 22:52 ` Luca Ceresoli
2016-03-06 10:13 ` [Buildroot] [PATCH 1/2] legal-info: fix detection of "override" packages Yann E. MORIN
2016-03-06 13:34 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306101914.GB3501@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox