From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] legal-info: fix detection of "override" packages
Date: Sun, 6 Mar 2016 14:34:37 +0100 [thread overview]
Message-ID: <20160306143437.6fc0ce20@free-electrons.com> (raw)
In-Reply-To: <1457134753-28197-1-git-send-email-luca@lucaceresoli.net>
Dear Luca Ceresoli,
On Sat, 5 Mar 2016 00:39:12 +0100, Luca Ceresoli wrote:
> The ifneq ($$($(2)_SITE_METHOD),override) test will always match
> because SITE_METHOD is never set to "override". The result is that
> some packages are downloaded and extracted unnecessarily, although
> they are (correctly) not saved in output/legal-info/.
>
> Fix by simply testing $(2)_OVERRIDE_SRCDIR instead: when empty, it
> indicates that the packages is neither a "local" site-method package
> nor a package that has its source directory overridden.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> ---
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-06 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 23:39 [Buildroot] [PATCH 1/2] legal-info: fix detection of "override" packages Luca Ceresoli
2016-03-04 23:39 ` [Buildroot] [PATCH 2/2] legal-info: remove outdated comment Luca Ceresoli
2016-03-06 10:19 ` Yann E. MORIN
2016-03-06 22:52 ` Luca Ceresoli
2016-03-06 10:13 ` [Buildroot] [PATCH 1/2] legal-info: fix detection of "override" packages Yann E. MORIN
2016-03-06 13:34 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306143437.6fc0ce20@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox