[Buildroot] [PATCH] zsh: don't use host pcre-config

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Baruch,

On Thu,  3 Mar 2016 23:46:10 +0200, Baruch Siach wrote:

> +diff --git a/configure.ac b/configure.ac
> +index c3bd713c126a..9947b16066b6 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -925,7 +925,7 @@ fi
> + if test x$enable_pcre = xyes; then
> + dnl pcre-config should probably be employed here
> + dnl AC_SEARCH_LIBS(pcre_compile, pcre)
> +-  LIBS="`pcre-config --libs` $LIBS"
> ++  LIBS="`$ac_cv_prog_PCRECONF --libs` $LIBS"

I think it is more correct to use the PRECONF variable rather than
ac_cv_prog_PCRECONF. Indeed, you have:

AC_CHECK_PROG([PCRECONF], pcre-config, pcre-config)

The documentation of AC_CHECK_PROG (at [1]) says:

? Macro: AC_CHECK_PROG (variable, prog-to-check-for, value-if-found, [value-if-not-found], [path = ?$PATH?], [reject])

   Check whether program prog-to-check-for exists in path. If it is
   found, set <variable> to value-if-found, otherwise to
   value-if-not-found, if given. Always pass over reject (an absolute
   file name) even if it is the first found in the search path; in that
   case, set <variable> using the absolute file name of the
   prog-to-check-for found that is not reject. If <variable> was already
   set, do nothing. Calls AC_SUBST for variable. The result of this
   test can be overridden by setting the variable <variable> or the cache
   variable ac_cv_prog_<variable>.

So to me, this means that the expected "output" of this macro is to set
<variable>, which in your case is PRECONF.

Best regards,

Thomas

[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com