Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] zsh: don't use host pcre-config
Date: Sun, 6 Mar 2016 19:50:05 +0200	[thread overview]
Message-ID: <20160306175005.GJ2877@tarshish> (raw)
In-Reply-To: <20160306143029.0f037047@free-electrons.com>

Hi Thomas,

On Sun, Mar 06, 2016 at 02:30:29PM +0100, Thomas Petazzoni wrote:
> On Sun, 6 Mar 2016 15:15:19 +0200, Baruch Siach wrote:
> 
> > > So to me, this means that the expected "output" of this macro is to set
> > > <variable>, which in your case is PRECONF.
> > 
> > Thanks for the information.
> 
> Note that the above was my own interpretation of the autoconf rules,
> and what I generally see in most configure.ac. People knowing autoconf
> better might disagree.
> 
> > This patch is now upstream, so I'll send another one upstream changing 
> > $ac_cv_prog_PCRECONF to $PCRECONF. If upstream accepts that I'll send v2 with 
> > a combined patch.
> 
> Notice that there is another place in the configure.ac where
> ac_cv_prog_PRECONF is already used.

Right. Provided that other ac_cv_ variables are used throughout zsh 
configure.ac do you think is is worth the trouble to clean up 
ac_cv_prog_PCRECONF use?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2016-03-06 17:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 21:46 [Buildroot] [PATCH] zsh: don't use host pcre-config Baruch Siach
2016-03-06 12:23 ` Thomas Petazzoni
2016-03-06 13:15   ` Baruch Siach
2016-03-06 13:30     ` Thomas Petazzoni
2016-03-06 17:50       ` Baruch Siach [this message]
2016-03-06 20:30         ` Thomas Petazzoni
2016-03-06 20:49 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160306175005.GJ2877@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox