* [Buildroot] [PATCH 1/1] taskd: new package
@ 2015-10-18 21:36 Ben Boeckel
2015-11-19 1:53 ` Ben Boeckel
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ben Boeckel @ 2015-10-18 21:36 UTC (permalink / raw)
To: buildroot
Taskwarrior is a task management suite of tools. Taskd is the
synchronization server for it.
Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
package/Config.in | 1 +
package/taskd/Config.in | 9 +++++++++
package/taskd/taskd.mk | 14 ++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 package/taskd/Config.in
create mode 100644 package/taskd/taskd.mk
diff --git a/package/Config.in b/package/Config.in
index 7746742..0620465 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1370,6 +1370,7 @@ endif
source "package/sshpass/Config.in"
source "package/strongswan/Config.in"
source "package/stunnel/Config.in"
+ source "package/taskd/Config.in"
source "package/tcpdump/Config.in"
source "package/tcping/Config.in"
source "package/tcpreplay/Config.in"
diff --git a/package/taskd/Config.in b/package/taskd/Config.in
new file mode 100644
index 0000000..534881f
--- /dev/null
+++ b/package/taskd/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_TASKD
+ bool "taskd"
+ select BR2_PACKAGE_GNUTLS
+ select BR2_PACKAGE_UTIL_LINUX
+ select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+ help
+ Task management synchronization daemon.
+
+ http://taskwarrior.org/
diff --git a/package/taskd/taskd.mk b/package/taskd/taskd.mk
new file mode 100644
index 0000000..0bdf81d
--- /dev/null
+++ b/package/taskd/taskd.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# taskd
+#
+################################################################################
+
+TASKD_VERSION = 1.1.0
+TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
+TASKD_SITE = http://taskwarrior.org/download
+TASKD_LICENSE = MIT
+TASKD_LICENSE_FILES = COPYING LICENSE
+TASKD_DEPENDENCIES = gnutls util-linux
+
+$(eval $(cmake-package))
--
2.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] taskd: new package
2015-10-18 21:36 [Buildroot] [PATCH 1/1] taskd: new package Ben Boeckel
@ 2015-11-19 1:53 ` Ben Boeckel
2016-03-08 20:17 ` Yann E. MORIN
2016-03-10 2:38 ` [Buildroot] [PATCH v2 " Ben Boeckel
2 siblings, 0 replies; 6+ messages in thread
From: Ben Boeckel @ 2015-11-19 1:53 UTC (permalink / raw)
To: buildroot
On Sun, Oct 18, 2015 at 17:36:27 -0400, Ben Boeckel wrote:
> Taskwarrior is a task management suite of tools. Taskd is the
> synchronization server for it.
Bump.
--Ben
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] taskd: new package
2015-10-18 21:36 [Buildroot] [PATCH 1/1] taskd: new package Ben Boeckel
2015-11-19 1:53 ` Ben Boeckel
@ 2016-03-08 20:17 ` Yann E. MORIN
2016-03-10 2:38 ` [Buildroot] [PATCH v2 " Ben Boeckel
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2016-03-08 20:17 UTC (permalink / raw)
To: buildroot
Ben, All,
Sorry for the dlong delay... Here's my review, there ar ea few comments,
see below...
On 2015-10-18 17:36 -0400, Ben Boeckel spake thusly:
> Taskwarrior is a task management suite of tools. Taskd is the
> synchronization server for it.
>
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/taskd/Config.in b/package/taskd/Config.in
> new file mode 100644
> index 0000000..534881f
> --- /dev/null
> +++ b/package/taskd/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_TASKD
> + bool "taskd"
taskd uses fork(), so you need to depend on BR2_USE_MMU.
> + select BR2_PACKAGE_GNUTLS
> + select BR2_PACKAGE_UTIL_LINUX
gnutls and util-linux both depend on BR2_USE_WCHAR, so you need to
propagate that dependency.
However, taskd depends on widechar for itself, so you also need that
dependency anyway.
Otherwise, sems OK...
Care to fix and respin, please? In the meantime, I marked your patch
as Changes Requested in our patchwork.
Thanks! :-)
Regards,
Yann E. MORIN.
> + select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> + help
> + Task management synchronization daemon.
> +
> + http://taskwarrior.org/
> diff --git a/package/taskd/taskd.mk b/package/taskd/taskd.mk
> new file mode 100644
> index 0000000..0bdf81d
> --- /dev/null
> +++ b/package/taskd/taskd.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# taskd
> +#
> +################################################################################
> +
> +TASKD_VERSION = 1.1.0
> +TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
> +TASKD_SITE = http://taskwarrior.org/download
> +TASKD_LICENSE = MIT
> +TASKD_LICENSE_FILES = COPYING LICENSE
> +TASKD_DEPENDENCIES = gnutls util-linux
> +
> +$(eval $(cmake-package))
> --
> 2.6.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] taskd: new package
2015-10-18 21:36 [Buildroot] [PATCH 1/1] taskd: new package Ben Boeckel
2015-11-19 1:53 ` Ben Boeckel
2016-03-08 20:17 ` Yann E. MORIN
@ 2016-03-10 2:38 ` Ben Boeckel
2016-03-10 22:31 ` Arnout Vandecappelle
2016-03-10 22:31 ` Thomas Petazzoni
2 siblings, 2 replies; 6+ messages in thread
From: Ben Boeckel @ 2016-03-10 2:38 UTC (permalink / raw)
To: buildroot
Taskwarrior is a task management suite of tools. Taskd is the
synchronization server for it.
Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
package/Config.in | 1 +
package/taskd/Config.in | 11 +++++++++++
package/taskd/taskd.mk | 14 ++++++++++++++
3 files changed, 26 insertions(+)
create mode 100644 package/taskd/Config.in
create mode 100644 package/taskd/taskd.mk
diff --git a/package/Config.in b/package/Config.in
index d916154..35a24ba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1489,6 +1489,7 @@ endif
source "package/sshpass/Config.in"
source "package/strongswan/Config.in"
source "package/stunnel/Config.in"
+ source "package/taskd/Config.in"
source "package/tcpdump/Config.in"
source "package/tcping/Config.in"
source "package/tcpreplay/Config.in"
diff --git a/package/taskd/Config.in b/package/taskd/Config.in
new file mode 100644
index 0000000..5b357f5
--- /dev/null
+++ b/package/taskd/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_TASKD
+ bool "taskd"
+ select BR2_PACKAGE_GNUTLS
+ select BR2_USE_MMU
+ select BR2_USE_WCHAR
+ select BR2_PACKAGE_UTIL_LINUX
+ select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+ help
+ Task management synchronization daemon.
+
+ http://taskwarrior.org/
diff --git a/package/taskd/taskd.mk b/package/taskd/taskd.mk
new file mode 100644
index 0000000..0bdf81d
--- /dev/null
+++ b/package/taskd/taskd.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# taskd
+#
+################################################################################
+
+TASKD_VERSION = 1.1.0
+TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
+TASKD_SITE = http://taskwarrior.org/download
+TASKD_LICENSE = MIT
+TASKD_LICENSE_FILES = COPYING LICENSE
+TASKD_DEPENDENCIES = gnutls util-linux
+
+$(eval $(cmake-package))
--
2.7.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] taskd: new package
2016-03-10 2:38 ` [Buildroot] [PATCH v2 " Ben Boeckel
@ 2016-03-10 22:31 ` Arnout Vandecappelle
2016-03-10 22:31 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2016-03-10 22:31 UTC (permalink / raw)
To: buildroot
On 03/10/16 03:38, Ben Boeckel wrote:
> Taskwarrior is a task management suite of tools. Taskd is the
> synchronization server for it.
>
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> ---
> package/Config.in | 1 +
> package/taskd/Config.in | 11 +++++++++++
> package/taskd/taskd.mk | 14 ++++++++++++++
> 3 files changed, 26 insertions(+)
> create mode 100644 package/taskd/Config.in
> create mode 100644 package/taskd/taskd.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index d916154..35a24ba 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1489,6 +1489,7 @@ endif
> source "package/sshpass/Config.in"
> source "package/strongswan/Config.in"
> source "package/stunnel/Config.in"
> + source "package/taskd/Config.in"
I don't think networking tools is the appropriate location. Miscellaneous maybe.
> source "package/tcpdump/Config.in"
> source "package/tcping/Config.in"
> source "package/tcpreplay/Config.in"
> diff --git a/package/taskd/Config.in b/package/taskd/Config.in
> new file mode 100644
> index 0000000..5b357f5
> --- /dev/null
> +++ b/package/taskd/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_TASKD
> + bool "taskd"
> + select BR2_PACKAGE_GNUTLS
> + select BR2_USE_MMU
> + select BR2_USE_WCHAR
You cannot select MMU and WCHAR, you need to depend on it. See
https://buildroot.org/downloads/manual/manual.html#depends-on-vs-select
The depends lines should come immediately after bool "taskd". There should also
be a comment at the end of the file that tells the user that taskd is only
available with wchar.
In addition to these two, it also needs C++11. So definitely
BR2_INSTALL_LIBSTDCPP, and probably also some minimal gcc version. Try with the
Arago ARMv7 2011.09 if 4.5 works; if it does, add
BR2_TOOLCHAIN_GCC_AT_LEAST_4_5, and so on until you find the minimal version.
> + select BR2_PACKAGE_UTIL_LINUX
> + select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> + help
> + Task management synchronization daemon.
> +
> + http://taskwarrior.org/
> diff --git a/package/taskd/taskd.mk b/package/taskd/taskd.mk
> new file mode 100644
> index 0000000..0bdf81d
> --- /dev/null
> +++ b/package/taskd/taskd.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# taskd
> +#
> +################################################################################
> +
> +TASKD_VERSION = 1.1.0
> +TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
This is the default, not needed.
> +TASKD_SITE = http://taskwarrior.org/download
> +TASKD_LICENSE = MIT
> +TASKD_LICENSE_FILES = COPYING LICENSE
AFAICS both files are identical, so specifying only one of them (COPYING) is
sufficient.
Regards,
Arnout
> +TASKD_DEPENDENCIES = gnutls util-linux
> +
> +$(eval $(cmake-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] taskd: new package
2016-03-10 2:38 ` [Buildroot] [PATCH v2 " Ben Boeckel
2016-03-10 22:31 ` Arnout Vandecappelle
@ 2016-03-10 22:31 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-03-10 22:31 UTC (permalink / raw)
To: buildroot
Ben,
On Wed, 9 Mar 2016 21:38:40 -0500, Ben Boeckel wrote:
> Taskwarrior is a task management suite of tools. Taskd is the
> synchronization server for it.
>
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
Thanks for this updated version! I've applied, but there were still a
few things to fix. Here are the changes I did:
[Thomas:
- use 'depends on' for BR2_USE_MMU, and add a comment indicating that
the dependency is due to the use of fork()
- use 'depends on' for BR2_USE_WCHAR, and add a comment indicating
that the dependency is due to gnutls and util-linux.
- add a hash file.]
Also, it would be a good idea to send a new patch that adds a simple
init script to start this server at boot time. This way, taskd can work
"out of the box".
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-10 22:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-18 21:36 [Buildroot] [PATCH 1/1] taskd: new package Ben Boeckel
2015-11-19 1:53 ` Ben Boeckel
2016-03-08 20:17 ` Yann E. MORIN
2016-03-10 2:38 ` [Buildroot] [PATCH v2 " Ben Boeckel
2016-03-10 22:31 ` Arnout Vandecappelle
2016-03-10 22:31 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox