* [Buildroot] [PATCH 0/2] gcc: preserve CXXFLAGS_FOR_TARGET
@ 2016-03-11 0:45 Max Filippov
2016-03-11 0:45 ` [Buildroot] [PATCH 1/2] " Max Filippov
2016-03-11 0:45 ` [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags" Max Filippov
0 siblings, 2 replies; 9+ messages in thread
From: Max Filippov @ 2016-03-11 0:45 UTC (permalink / raw)
To: buildroot
Hello,
this series backports gcc fix that preserves CXXFLAGS_FOR_TARGET and
reverts related xtensa-specific workaround. See discussion at
https://patchwork.ozlabs.org/patch/479074/
Max Filippov (2):
gcc: preserve CXXFLAGS_FOR_TARGET
Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with
--enable-cxx-flags"
package/gcc/4.8.5/130-pr43538.patch | 25 +++++++++++++++++++++++++
package/gcc/4.9.3/130-pr43538.patch | 25 +++++++++++++++++++++++++
package/gcc/gcc-final/gcc-final.mk | 4 ----
3 files changed, 50 insertions(+), 4 deletions(-)
create mode 100644 package/gcc/4.8.5/130-pr43538.patch
create mode 100644 package/gcc/4.9.3/130-pr43538.patch
--
2.1.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: preserve CXXFLAGS_FOR_TARGET
2016-03-11 0:45 [Buildroot] [PATCH 0/2] gcc: preserve CXXFLAGS_FOR_TARGET Max Filippov
@ 2016-03-11 0:45 ` Max Filippov
2016-03-12 9:27 ` Arnout Vandecappelle
2016-03-12 22:56 ` Yann E. MORIN
2016-03-11 0:45 ` [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags" Max Filippov
1 sibling, 2 replies; 9+ messages in thread
From: Max Filippov @ 2016-03-11 0:45 UTC (permalink / raw)
To: buildroot
gcc-4.8.x and gcc-4.9.x don't propagate CXXFLAGS_FOR_TARGET to CXXFLAGS
for libstdc++ build. As a result libstdc++ is built without
TARGET_CFLAGS and may fail to link with applications using it, see e.g.
http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
Instead of passing TARGET_ABI or TARGET_CFLAGS for libstdc++ in
--enable-cxx-flags parameter backport the patch that fixes propagation
of CXXFLAGS_FOR_TARGET to CXXFLAGS.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
package/gcc/4.8.5/130-pr43538.patch | 25 +++++++++++++++++++++++++
package/gcc/4.9.3/130-pr43538.patch | 25 +++++++++++++++++++++++++
2 files changed, 50 insertions(+)
create mode 100644 package/gcc/4.8.5/130-pr43538.patch
create mode 100644 package/gcc/4.9.3/130-pr43538.patch
diff --git a/package/gcc/4.8.5/130-pr43538.patch b/package/gcc/4.8.5/130-pr43538.patch
new file mode 100644
index 0000000..19e57bb
--- /dev/null
+++ b/package/gcc/4.8.5/130-pr43538.patch
@@ -0,0 +1,25 @@
+From c037df1be41f8daf4d581d7ffa4ec8cfa640bccf Mon Sep 17 00:00:00 2001
+From: glisse <glisse@138bc75d-0d04-0410-961f-82ee72b054a4>
+Date: Fri, 25 Apr 2014 08:03:08 +0000
+Subject: [PATCH] 2014-04-25 Marc Glisse <marc.glisse@inria.fr>
+
+ PR target/43538
+ * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
+
+
+git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk at 209784 138bc75d-0d04-0410-961f-82ee72b054a4
+Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
+---
+ config/mt-gnu | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/config/mt-gnu b/config/mt-gnu
+index 15bf417..5c696f5 100644
+--- a/config/mt-gnu
++++ b/config/mt-gnu
+@@ -1 +1 @@
+-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
++CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE
+--
+2.1.4
+
diff --git a/package/gcc/4.9.3/130-pr43538.patch b/package/gcc/4.9.3/130-pr43538.patch
new file mode 100644
index 0000000..19e57bb
--- /dev/null
+++ b/package/gcc/4.9.3/130-pr43538.patch
@@ -0,0 +1,25 @@
+From c037df1be41f8daf4d581d7ffa4ec8cfa640bccf Mon Sep 17 00:00:00 2001
+From: glisse <glisse@138bc75d-0d04-0410-961f-82ee72b054a4>
+Date: Fri, 25 Apr 2014 08:03:08 +0000
+Subject: [PATCH] 2014-04-25 Marc Glisse <marc.glisse@inria.fr>
+
+ PR target/43538
+ * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
+
+
+git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk at 209784 138bc75d-0d04-0410-961f-82ee72b054a4
+Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
+---
+ config/mt-gnu | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/config/mt-gnu b/config/mt-gnu
+index 15bf417..5c696f5 100644
+--- a/config/mt-gnu
++++ b/config/mt-gnu
+@@ -1 +1 @@
+-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
++CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE
+--
+2.1.4
+
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags"
2016-03-11 0:45 [Buildroot] [PATCH 0/2] gcc: preserve CXXFLAGS_FOR_TARGET Max Filippov
2016-03-11 0:45 ` [Buildroot] [PATCH 1/2] " Max Filippov
@ 2016-03-11 0:45 ` Max Filippov
2016-03-12 9:27 ` Arnout Vandecappelle
2016-03-12 22:56 ` Yann E. MORIN
1 sibling, 2 replies; 9+ messages in thread
From: Max Filippov @ 2016-03-11 0:45 UTC (permalink / raw)
To: buildroot
This reverts commit 2dcab526a97d1dbcb73c3cd578e5bf2853853a10.
Now that gcc correctly propagates CXXFLAGS_FOR_TARGET for libstdc++
build this is no longer needed.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
package/gcc/gcc-final/gcc-final.mk | 4 ----
1 file changed, 4 deletions(-)
diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
index dbdb615..69fdc0c 100644
--- a/package/gcc/gcc-final/gcc-final.mk
+++ b/package/gcc/gcc-final/gcc-final.mk
@@ -195,8 +195,4 @@ endef
HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_FINAL_INSTALL_USR_LIBS
endif
-ifeq ($(BR2_xtensa),y)
-HOST_GCC_FINAL_CONF_OPTS += --enable-cxx-flags="$(TARGET_ABI)"
-endif
-
$(eval $(host-autotools-package))
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags"
2016-03-11 0:45 ` [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags" Max Filippov
@ 2016-03-12 9:27 ` Arnout Vandecappelle
2016-03-12 22:56 ` Yann E. MORIN
1 sibling, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2016-03-12 9:27 UTC (permalink / raw)
To: buildroot
On 03/11/16 01:45, Max Filippov wrote:
> This reverts commit 2dcab526a97d1dbcb73c3cd578e5bf2853853a10.
>
> Now that gcc correctly propagates CXXFLAGS_FOR_TARGET for libstdc++
> build this is no longer needed.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/gcc/gcc-final/gcc-final.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
> index dbdb615..69fdc0c 100644
> --- a/package/gcc/gcc-final/gcc-final.mk
> +++ b/package/gcc/gcc-final/gcc-final.mk
> @@ -195,8 +195,4 @@ endef
> HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_FINAL_INSTALL_USR_LIBS
> endif
>
> -ifeq ($(BR2_xtensa),y)
> -HOST_GCC_FINAL_CONF_OPTS += --enable-cxx-flags="$(TARGET_ABI)"
> -endif
> -
> $(eval $(host-autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: preserve CXXFLAGS_FOR_TARGET
2016-03-11 0:45 ` [Buildroot] [PATCH 1/2] " Max Filippov
@ 2016-03-12 9:27 ` Arnout Vandecappelle
2016-03-12 22:56 ` Yann E. MORIN
1 sibling, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2016-03-12 9:27 UTC (permalink / raw)
To: buildroot
On 03/11/16 01:45, Max Filippov wrote:
> gcc-4.8.x and gcc-4.9.x don't propagate CXXFLAGS_FOR_TARGET to CXXFLAGS
It would have been good to mention explicitly that it's not done for
deprecated gcc-4.7.x and that it's already fixed in gcc-5.x.
> for libstdc++ build. As a result libstdc++ is built without
> TARGET_CFLAGS and may fail to link with applications using it, see e.g.
>
> http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
>
> Instead of passing TARGET_ABI or TARGET_CFLAGS for libstdc++ in
> --enable-cxx-flags parameter backport the patch that fixes propagation
> of CXXFLAGS_FOR_TARGET to CXXFLAGS.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/gcc/4.8.5/130-pr43538.patch | 25 +++++++++++++++++++++++++
> package/gcc/4.9.3/130-pr43538.patch | 25 +++++++++++++++++++++++++
> 2 files changed, 50 insertions(+)
> create mode 100644 package/gcc/4.8.5/130-pr43538.patch
> create mode 100644 package/gcc/4.9.3/130-pr43538.patch
>
> diff --git a/package/gcc/4.8.5/130-pr43538.patch b/package/gcc/4.8.5/130-pr43538.patch
> new file mode 100644
> index 0000000..19e57bb
> --- /dev/null
> +++ b/package/gcc/4.8.5/130-pr43538.patch
> @@ -0,0 +1,25 @@
> +From c037df1be41f8daf4d581d7ffa4ec8cfa640bccf Mon Sep 17 00:00:00 2001
> +From: glisse <glisse@138bc75d-0d04-0410-961f-82ee72b054a4>
> +Date: Fri, 25 Apr 2014 08:03:08 +0000
> +Subject: [PATCH] 2014-04-25 Marc Glisse <marc.glisse@inria.fr>
> +
> + PR target/43538
> + * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
> +
> +
> +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk at 209784 138bc75d-0d04-0410-961f-82ee72b054a4
> +Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> +---
> + config/mt-gnu | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/config/mt-gnu b/config/mt-gnu
> +index 15bf417..5c696f5 100644
> +--- a/config/mt-gnu
> ++++ b/config/mt-gnu
> +@@ -1 +1 @@
> +-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
> ++CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE
> +--
> +2.1.4
> +
> diff --git a/package/gcc/4.9.3/130-pr43538.patch b/package/gcc/4.9.3/130-pr43538.patch
> new file mode 100644
> index 0000000..19e57bb
> --- /dev/null
> +++ b/package/gcc/4.9.3/130-pr43538.patch
> @@ -0,0 +1,25 @@
> +From c037df1be41f8daf4d581d7ffa4ec8cfa640bccf Mon Sep 17 00:00:00 2001
> +From: glisse <glisse@138bc75d-0d04-0410-961f-82ee72b054a4>
> +Date: Fri, 25 Apr 2014 08:03:08 +0000
> +Subject: [PATCH] 2014-04-25 Marc Glisse <marc.glisse@inria.fr>
> +
> + PR target/43538
> + * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
> +
> +
> +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk at 209784 138bc75d-0d04-0410-961f-82ee72b054a4
> +Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> +---
> + config/mt-gnu | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/config/mt-gnu b/config/mt-gnu
> +index 15bf417..5c696f5 100644
> +--- a/config/mt-gnu
> ++++ b/config/mt-gnu
> +@@ -1 +1 @@
> +-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
> ++CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE
> +--
> +2.1.4
> +
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: preserve CXXFLAGS_FOR_TARGET
2016-03-11 0:45 ` [Buildroot] [PATCH 1/2] " Max Filippov
2016-03-12 9:27 ` Arnout Vandecappelle
@ 2016-03-12 22:56 ` Yann E. MORIN
2016-03-13 3:18 ` Max Filippov
1 sibling, 1 reply; 9+ messages in thread
From: Yann E. MORIN @ 2016-03-12 22:56 UTC (permalink / raw)
To: buildroot
Max, All,
On 2016-03-11 03:45 +0300, Max Filippov spake thusly:
> gcc-4.8.x and gcc-4.9.x don't propagate CXXFLAGS_FOR_TARGET to CXXFLAGS
> for libstdc++ build. As a result libstdc++ is built without
> TARGET_CFLAGS and may fail to link with applications using it, see e.g.
>
> http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
>
> Instead of passing TARGET_ABI or TARGET_CFLAGS for libstdc++ in
> --enable-cxx-flags parameter backport the patch that fixes propagation
> of CXXFLAGS_FOR_TARGET to CXXFLAGS.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> package/gcc/4.8.5/130-pr43538.patch | 25 +++++++++++++++++++++++++
> package/gcc/4.9.3/130-pr43538.patch | 25 +++++++++++++++++++++++++
As already noticed by Arnout, this is not done for gcc-4.7. Is it
because it is not affected by the issue, or because upstream has not
fixed it?
Is the latter case, we'd still have the issue for gcc-4.7, no? Or do we
not care about it any more (I don't, TBH...)?
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> 2 files changed, 50 insertions(+)
> create mode 100644 package/gcc/4.8.5/130-pr43538.patch
> create mode 100644 package/gcc/4.9.3/130-pr43538.patch
>
> diff --git a/package/gcc/4.8.5/130-pr43538.patch b/package/gcc/4.8.5/130-pr43538.patch
> new file mode 100644
> index 0000000..19e57bb
> --- /dev/null
> +++ b/package/gcc/4.8.5/130-pr43538.patch
> @@ -0,0 +1,25 @@
> +From c037df1be41f8daf4d581d7ffa4ec8cfa640bccf Mon Sep 17 00:00:00 2001
> +From: glisse <glisse@138bc75d-0d04-0410-961f-82ee72b054a4>
> +Date: Fri, 25 Apr 2014 08:03:08 +0000
> +Subject: [PATCH] 2014-04-25 Marc Glisse <marc.glisse@inria.fr>
> +
> + PR target/43538
> + * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
> +
> +
> +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk at 209784 138bc75d-0d04-0410-961f-82ee72b054a4
> +Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> +---
> + config/mt-gnu | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/config/mt-gnu b/config/mt-gnu
> +index 15bf417..5c696f5 100644
> +--- a/config/mt-gnu
> ++++ b/config/mt-gnu
> +@@ -1 +1 @@
> +-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
> ++CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE
> +--
> +2.1.4
> +
> diff --git a/package/gcc/4.9.3/130-pr43538.patch b/package/gcc/4.9.3/130-pr43538.patch
> new file mode 100644
> index 0000000..19e57bb
> --- /dev/null
> +++ b/package/gcc/4.9.3/130-pr43538.patch
> @@ -0,0 +1,25 @@
> +From c037df1be41f8daf4d581d7ffa4ec8cfa640bccf Mon Sep 17 00:00:00 2001
> +From: glisse <glisse@138bc75d-0d04-0410-961f-82ee72b054a4>
> +Date: Fri, 25 Apr 2014 08:03:08 +0000
> +Subject: [PATCH] 2014-04-25 Marc Glisse <marc.glisse@inria.fr>
> +
> + PR target/43538
> + * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
> +
> +
> +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk at 209784 138bc75d-0d04-0410-961f-82ee72b054a4
> +Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> +---
> + config/mt-gnu | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/config/mt-gnu b/config/mt-gnu
> +index 15bf417..5c696f5 100644
> +--- a/config/mt-gnu
> ++++ b/config/mt-gnu
> +@@ -1 +1 @@
> +-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
> ++CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE
> +--
> +2.1.4
> +
> --
> 2.1.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags"
2016-03-11 0:45 ` [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags" Max Filippov
2016-03-12 9:27 ` Arnout Vandecappelle
@ 2016-03-12 22:56 ` Yann E. MORIN
1 sibling, 0 replies; 9+ messages in thread
From: Yann E. MORIN @ 2016-03-12 22:56 UTC (permalink / raw)
To: buildroot
Max, All,
On 2016-03-11 03:45 +0300, Max Filippov spake thusly:
> This reverts commit 2dcab526a97d1dbcb73c3cd578e5bf2853853a10.
>
> Now that gcc correctly propagates CXXFLAGS_FOR_TARGET for libstdc++
> build this is no longer needed.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/gcc/gcc-final/gcc-final.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
> index dbdb615..69fdc0c 100644
> --- a/package/gcc/gcc-final/gcc-final.mk
> +++ b/package/gcc/gcc-final/gcc-final.mk
> @@ -195,8 +195,4 @@ endef
> HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_FINAL_INSTALL_USR_LIBS
> endif
>
> -ifeq ($(BR2_xtensa),y)
> -HOST_GCC_FINAL_CONF_OPTS += --enable-cxx-flags="$(TARGET_ABI)"
> -endif
> -
> $(eval $(host-autotools-package))
> --
> 2.1.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: preserve CXXFLAGS_FOR_TARGET
2016-03-12 22:56 ` Yann E. MORIN
@ 2016-03-13 3:18 ` Max Filippov
2016-03-13 22:23 ` Arnout Vandecappelle
0 siblings, 1 reply; 9+ messages in thread
From: Max Filippov @ 2016-03-13 3:18 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Sun, Mar 13, 2016 at 1:56 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> On 2016-03-11 03:45 +0300, Max Filippov spake thusly:
>> gcc-4.8.x and gcc-4.9.x don't propagate CXXFLAGS_FOR_TARGET to CXXFLAGS
>> for libstdc++ build. As a result libstdc++ is built without
>> TARGET_CFLAGS and may fail to link with applications using it, see e.g.
>>
>> http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
>>
>> Instead of passing TARGET_ABI or TARGET_CFLAGS for libstdc++ in
>> --enable-cxx-flags parameter backport the patch that fixes propagation
>> of CXXFLAGS_FOR_TARGET to CXXFLAGS.
>>
>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>> ---
>> package/gcc/4.8.5/130-pr43538.patch | 25 +++++++++++++++++++++++++
>> package/gcc/4.9.3/130-pr43538.patch | 25 +++++++++++++++++++++++++
>
> As already noticed by Arnout, this is not done for gcc-4.7. Is it
> because it is not affected by the issue, or because upstream has not
> fixed it?
It's me not seeing 4.7.x in the menuconfig list. Yes, 4.7.x is affected too.
I'll send a new version with backport to 4.7.x.
> Is the latter case, we'd still have the issue for gcc-4.7, no? Or do we
> not care about it any more (I don't, TBH...)?
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: preserve CXXFLAGS_FOR_TARGET
2016-03-13 3:18 ` Max Filippov
@ 2016-03-13 22:23 ` Arnout Vandecappelle
0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2016-03-13 22:23 UTC (permalink / raw)
To: buildroot
On 03/13/16 04:18, Max Filippov wrote:
> Hi Yann,
>
> On Sun, Mar 13, 2016 at 1:56 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> On 2016-03-11 03:45 +0300, Max Filippov spake thusly:
>>> gcc-4.8.x and gcc-4.9.x don't propagate CXXFLAGS_FOR_TARGET to CXXFLAGS
>>> for libstdc++ build. As a result libstdc++ is built without
>>> TARGET_CFLAGS and may fail to link with applications using it, see e.g.
>>>
>>> http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
>>>
>>> Instead of passing TARGET_ABI or TARGET_CFLAGS for libstdc++ in
>>> --enable-cxx-flags parameter backport the patch that fixes propagation
>>> of CXXFLAGS_FOR_TARGET to CXXFLAGS.
>>>
>>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>>> ---
>>> package/gcc/4.8.5/130-pr43538.patch | 25 +++++++++++++++++++++++++
>>> package/gcc/4.9.3/130-pr43538.patch | 25 +++++++++++++++++++++++++
>>
>> As already noticed by Arnout, this is not done for gcc-4.7. Is it
>> because it is not affected by the issue, or because upstream has not
>> fixed it?
>
> It's me not seeing 4.7.x in the menuconfig list. Yes, 4.7.x is affected too.
> I'll send a new version with backport to 4.7.x.
Since 4.7 is deprecated, I don't think there is a need to add a patch for it.
So my Reviewed-by stands.
Regards,
Arnout
>
>> Is the latter case, we'd still have the issue for gcc-4.7, no? Or do we
>> not care about it any more (I don't, TBH...)?
>>
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-03-13 22:23 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-11 0:45 [Buildroot] [PATCH 0/2] gcc: preserve CXXFLAGS_FOR_TARGET Max Filippov
2016-03-11 0:45 ` [Buildroot] [PATCH 1/2] " Max Filippov
2016-03-12 9:27 ` Arnout Vandecappelle
2016-03-12 22:56 ` Yann E. MORIN
2016-03-13 3:18 ` Max Filippov
2016-03-13 22:23 ` Arnout Vandecappelle
2016-03-11 0:45 ` [Buildroot] [PATCH 2/2] Revert "gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags" Max Filippov
2016-03-12 9:27 ` Arnout Vandecappelle
2016-03-12 22:56 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox