From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] slang: make install-static do install-pkgconfig
Date: Sun, 13 Mar 2016 21:47:30 +0100 [thread overview]
Message-ID: <20160313204730.GC3488@free.fr> (raw)
In-Reply-To: <87fuvuf6qa.fsf@dell.be.48ers.dk>
Peter, All,
On 2016-03-13 21:44 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> Hi,
>
> >> Patch description and signed-off-by missing. Alternatively we can drop
> >> the patch and just pass install-pkgconfig to the 'make install' step as
> >> we already need to use a custom make target anyway.
>
> > That's what Max did in his first patch, and I asked him to do it in our
> > patch.
> > The .pc file is not installed for static-only because *we* added a patch
> > that breaks down install into install-staging and install-shared.
>
> But that patch is an upstream patch:
>
> Repository: git://git.jedsoft.org/git/slang.git
> Commit ID: 3796db6fb94a2fc7fe2fb0b6918501b69a4d3a02
> Author: John E. Davis <jed@jedsoft.org>
Oh...
> So just changing what the patch does without updating the comment is
> imho not the right way to go. We should instead add a 0003 patch and
> send it upstream.
Definitely.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-03-13 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 3:06 [Buildroot] [PATCH] slang: make install-static do install-pkgconfig Max Filippov
2016-03-13 20:14 ` Peter Korsgaard
2016-03-13 20:17 ` Thomas Petazzoni
2016-03-13 20:43 ` Peter Korsgaard
2016-03-13 20:20 ` Yann E. MORIN
2016-03-13 20:44 ` Peter Korsgaard
2016-03-13 20:47 ` Yann E. MORIN [this message]
2016-03-13 20:20 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313204730.GC3488@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox