From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] slang: make install-static do install-pkgconfig
Date: Sun, 13 Mar 2016 21:44:29 +0100 [thread overview]
Message-ID: <87fuvuf6qa.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160313202028.GA3488@free.fr> (Yann E. MORIN's message of "Sun, 13 Mar 2016 21:20:28 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Hi,
>> Patch description and signed-off-by missing. Alternatively we can drop
>> the patch and just pass install-pkgconfig to the 'make install' step as
>> we already need to use a custom make target anyway.
> That's what Max did in his first patch, and I asked him to do it in our
> patch.
> The .pc file is not installed for static-only because *we* added a patch
> that breaks down install into install-staging and install-shared.
But that patch is an upstream patch:
Repository: git://git.jedsoft.org/git/slang.git
Commit ID: 3796db6fb94a2fc7fe2fb0b6918501b69a4d3a02
Author: John E. Davis <jed@jedsoft.org>
So just changing what the patch does without updating the comment is
imho not the right way to go. We should instead add a 0003 patch and
send it upstream.
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2016-03-13 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 3:06 [Buildroot] [PATCH] slang: make install-static do install-pkgconfig Max Filippov
2016-03-13 20:14 ` Peter Korsgaard
2016-03-13 20:17 ` Thomas Petazzoni
2016-03-13 20:43 ` Peter Korsgaard
2016-03-13 20:20 ` Yann E. MORIN
2016-03-13 20:44 ` Peter Korsgaard [this message]
2016-03-13 20:47 ` Yann E. MORIN
2016-03-13 20:20 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuvuf6qa.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox