[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Bernd Kuhls]

Hi,

before sending a patch which fixes a problem with host gcc < 4.7 I would 
like to ask whether this patch is needed@all. Are there autobuilders 
where the host version of gcc is < 4.7?

While testing Kodi compilation using buildroot master this error occurs:

cc1plus: error: unrecognized command line option '-std=c++11'
make[4]: *** [md5.o] Error 1
make[4]: *** Waiting for unfinished jobs....
cc1plus: error: unrecognized command line option '-std=c++11'cc1plus: 
error: unrecognized command line option '-std=c++11'

make[4]: *** [DecoderManager.o] Error 1
make[4]: *** [XBTFWriter.o] Error 1
cc1plus: error: unrecognized command line option '-std=c++11'
make[4]: *** [TexturePacker.o] Error 1
cc1plus: error: unrecognized command line option '-std=c++11'
make[4]: *** [decoder/PNGDecoder.o] Error 1
make[3]: *** [all] Error 2
make[2]: *** [native/TexturePacker] Error 2
make[1]: *** [/home/fli4l/buildroot/output/build/kodi-16.0-
Jarvis/.stamp_configured] Error 2

while the host version of TexturePacker is compiled during autoreconf on 
Ubuntu 12.04.5 with "gcc-Version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)".

To fix the problem change "-std=c++11" to "-std=c++0x" in tools/depends/
native/TexturePacker/src/Makefile.am.

To reproduce the bug use this defconfig:

BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_KODI=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_I965=y
BR2_PACKAGE_XORG7=y

Regards, Bernd

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Arnout Vandecappelle]

On 03/13/16 22:53, Bernd Kuhls wrote:
> Hi,
>
> before sending a patch which fixes a problem with host gcc < 4.7 I would
> like to ask whether this patch is needed at all. Are there autobuilders
> where the host version of gcc is < 4.7?

  Well, RHEL6 has gcc 4.4, and ideally we'd like to support RHEL5 as well (many 
companies are still based on it).

  But we have a simple solution now: kodi depends on BR2_HOST_GCC_AT_LEAST_4_7. 
Cfr. nodejs for instance, which faces the same problem.

  Regards,
  Arnout

>
> While testing Kodi compilation using buildroot master this error occurs:
>
> cc1plus: error: unrecognized command line option '-std=c++11'
> make[4]: *** [md5.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> cc1plus: error: unrecognized command line option '-std=c++11'cc1plus:
> error: unrecognized command line option '-std=c++11'
>
> make[4]: *** [DecoderManager.o] Error 1
> make[4]: *** [XBTFWriter.o] Error 1
> cc1plus: error: unrecognized command line option '-std=c++11'
> make[4]: *** [TexturePacker.o] Error 1
> cc1plus: error: unrecognized command line option '-std=c++11'
> make[4]: *** [decoder/PNGDecoder.o] Error 1
> make[3]: *** [all] Error 2
> make[2]: *** [native/TexturePacker] Error 2
> make[1]: *** [/home/fli4l/buildroot/output/build/kodi-16.0-
> Jarvis/.stamp_configured] Error 2
>
> while the host version of TexturePacker is compiled during autoreconf on
> Ubuntu 12.04.5 with "gcc-Version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)".
>
> To fix the problem change "-std=c++11" to "-std=c++0x" in tools/depends/
> native/TexturePacker/src/Makefile.am.
>
> To reproduce the bug use this defconfig:
>
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> BR2_TOOLCHAIN_BUILDROOT_CXX=y
> BR2_PACKAGE_KODI=y
> BR2_PACKAGE_MESA3D=y
> BR2_PACKAGE_MESA3D_DRI_DRIVER_I965=y
> BR2_PACKAGE_XORG7=y
>
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 03/13/16 22:53, Bernd Kuhls wrote:
 >> Hi,
 >> 
 >> before sending a patch which fixes a problem with host gcc < 4.7 I would
 >> like to ask whether this patch is needed at all. Are there autobuilders
 >> where the host version of gcc is < 4.7?

 >  Well, RHEL6 has gcc 4.4, and ideally we'd like to support RHEL5 as
 > well (many companies are still based on it).

 >  But we have a simple solution now: kodi depends on
 > BR2_HOST_GCC_AT_LEAST_4_7. Cfr. nodejs for instance, which faces the
 > same problem.

Indeed. And gcc10 uses host-gcc 4.4:

Using built-in specs.
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 4.4.5-8' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.4 --enable-shared --enable-multiarch --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --with-arch-32=i586 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.4.5 (Debian 4.4.5-8)

-- 
Bye, Peter Korsgaard

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Thomas Petazzoni]

Hello,

On Mon, 14 Mar 2016 14:31:20 +0100, Peter Korsgaard wrote:

>  >  But we have a simple solution now: kodi depends on
>  > BR2_HOST_GCC_AT_LEAST_4_7. Cfr. nodejs for instance, which faces the
>  > same problem.
> 
> Indeed. And gcc10 uses host-gcc 4.4:

I'm also using gcc 4.4 on Free Electrons build server. Well, I should
say that our machine is not using such an ancient system (we have a
reasonably recent Ubuntu 14.04 with gcc 4.8), but I run the Buildroot
builds in an intentionally old Debian 6.0 chroot, which has this old
4.4 gcc.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Bernd Kuhls]

Am Sun, 13 Mar 2016 23:19:50 +0100 schrieb Arnout Vandecappelle:

> On 03/13/16 22:53, Bernd Kuhls wrote:
>> Hi,
>>
>> before sending a patch which fixes a problem with host gcc < 4.7 I
>> would like to ask whether this patch is needed at all. Are there
>> autobuilders where the host version of gcc is < 4.7?
> 
>   Well, RHEL6 has gcc 4.4, and ideally we'd like to support RHEL5 as
>   well (many
> companies are still based on it).
> 
>   But we have a simple solution now: kodi depends on
>   BR2_HOST_GCC_AT_LEAST_4_7.

Hi,

with my proposed patch we can lower it to BR2_HOST_GCC_AT_LEAST_4_6 ;)

With gcc 4.4 (testing with Ubuntu 10.04.4) adding -std=c++0xwill not be 
enough:

XBTFWriter.cpp: In constructor ?CXBTFWriter::CXBTFWriter(const 
std::string&)?:
XBTFWriter.cpp:42: error: ?nullptr? was not declared in this scope

Looking around for approaches to solve the problem I found these two 
commits:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae45a2c9d678
https://github.com/grpc/grpc/
commit/3ff350cf96676f2c32c6913aceeabf84a15f3715

Is either one good enough so I can try to solve the problem? I am asking 
in advance because I am not a c++ programmer.

Regards, Bernd

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Thomas Petazzoni]

Hello,

On Mon, 14 Mar 2016 20:23:16 +0100, Bernd Kuhls wrote:

> with my proposed patch we can lower it to BR2_HOST_GCC_AT_LEAST_4_6 ;)
> 
> With gcc 4.4 (testing with Ubuntu 10.04.4) adding -std=c++0xwill not be 
> enough:
> 
> XBTFWriter.cpp: In constructor ?CXBTFWriter::CXBTFWriter(const 
> std::string&)?:
> XBTFWriter.cpp:42: error: ?nullptr? was not declared in this scope
> 
> Looking around for approaches to solve the problem I found these two 
> commits:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/ae45a2c9d678
> https://github.com/grpc/grpc/
> commit/3ff350cf96676f2c32c6913aceeabf84a15f3715

Why do you want to solve the problem? Adding a dependency on
BR2_HOST_GCC_AT_LEAST_4_6 is perfectly fine, especially for such
a modern, complex C++ software like Kodi.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Yann E. MORIN]

Bernd, Thomas, All,

On 2016-03-14 23:05 +0100, Thomas Petazzoni spake thusly:
> On Mon, 14 Mar 2016 20:23:16 +0100, Bernd Kuhls wrote:
> > with my proposed patch we can lower it to BR2_HOST_GCC_AT_LEAST_4_6 ;)
> > 
> > With gcc 4.4 (testing with Ubuntu 10.04.4) adding -std=c++0xwill not be 
> > enough:
> > 
> > XBTFWriter.cpp: In constructor ?CXBTFWriter::CXBTFWriter(const 
> > std::string&)?:
> > XBTFWriter.cpp:42: error: ?nullptr? was not declared in this scope
> > 
> > Looking around for approaches to solve the problem I found these two 
> > commits:
> > 
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/ae45a2c9d678
> > https://github.com/grpc/grpc/
> > commit/3ff350cf96676f2c32c6913aceeabf84a15f3715
> 
> Why do you want to solve the problem? Adding a dependency on
> BR2_HOST_GCC_AT_LEAST_4_6 is perfectly fine, especially for such
> a modern, complex C++ software like Kodi.

Totally agreed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] Bug during Kodi compile with host gcc <4.7, question regarding autobuilders

[Bernd Kuhls]

Am Mon, 14 Mar 2016 23:05:03 +0100 schrieb Thomas Petazzoni:

> Why do you want to solve the problem? Adding a dependency on
> BR2_HOST_GCC_AT_LEAST_4_6 is perfectly fine, especially for such a
> modern, complex C++ software like Kodi.

Hi Thomas,

to support as many systems as possible, but for me having support for 
host gcc 4.6 is sufficient so I sent a PR upstream:

https://github.com/xbmc/xbmc/pull/9378

Now I am waiting for the upstream reaction, depending on it I will send a 
patch for buildroot.

Regards, Bernd