From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] lxc: remove dependency on headers >= 3.0
Date: Wed, 16 Mar 2016 23:36:11 +0100 [thread overview]
Message-ID: <20160316233611.6c664973@free-electrons.com> (raw)
In-Reply-To: <87twk66onk.fsf@dell.be.48ers.dk>
Hello,
On Wed, 16 Mar 2016 23:31:11 +0100, Peter Korsgaard wrote:
> But can missing setns() really just be ignored and still have a working
> lxc? From the code snippets failures look critical.
Yes, runtime it definitely won't work. But since the LXC code was
already planning on being able to build on systems not providing those
syscalls, I was staying in line with this decision.
> From the man page:
>
> VERSIONS
>
> The setns() system call first appeared in Linux in kernel 3.0;
> library support was added to glibc in version 2.14.
>
> So I think it is safer to just keep the >= 3.0 headers dependency.
But I agree with you, it's probably better to keep the >= 3.0 headers
dependency. However, the comment that the dependency comes from libcap
should be changed.
Should I change a patch to fix this?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-16 22:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 20:20 [Buildroot] [PATCH 1/4] libcap: bump version Thomas Petazzoni
2016-03-16 20:20 ` [Buildroot] [PATCH 2/4] libcap: add patch to fix build issue with old kernel headers Thomas Petazzoni
2016-03-16 22:16 ` Peter Korsgaard
2016-03-16 22:34 ` Thomas Petazzoni
2016-03-16 22:44 ` Peter Korsgaard
2016-03-17 8:20 ` Thomas Petazzoni
2016-03-16 20:20 ` [Buildroot] [PATCH 3/4] libcap, cdrkit, dvdrw-tools, fastd, squid: remove headers >= 3.0 dependency Thomas Petazzoni
2016-03-16 22:23 ` Peter Korsgaard
2016-03-16 20:20 ` [Buildroot] [PATCH 4/4] lxc: remove dependency on headers >= 3.0 Thomas Petazzoni
2016-03-16 22:31 ` Peter Korsgaard
2016-03-16 22:36 ` Thomas Petazzoni [this message]
2016-03-16 22:45 ` Peter Korsgaard
2016-03-16 22:49 ` Arnout Vandecappelle
2016-03-17 6:22 ` Peter Korsgaard
2016-03-16 22:09 ` [Buildroot] [PATCH 1/4] libcap: bump version Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316233611.6c664973@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox