From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] libcap: bump version
Date: Wed, 16 Mar 2016 23:09:32 +0100 [thread overview]
Message-ID: <877fh28483.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1458159611-5613-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Wed, 16 Mar 2016 21:20:08 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> attr is no longer a dependency, not even optional.
> Refresh our patches, and drop the backport from upstream.
It would have been good to mention something about the new host-gperf
dependency, but ok.
> define HOST_LIBCAP_BUILD_CMDS
> $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)\
> - LIBATTR=yes RAISE_SETFCAP=no
> + RAISE_SETFCAP=no
> endef
> define HOST_LIBCAP_INSTALL_CMDS
> $(HOST_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
> - LIBATTR=yes RAISE_SETFCAP=no prefix=/usr lib=lib install
> + RAISE_SETFCAP=no prefix=/usr lib=lib install
> endef
Not related to this bump, but this looks wrong. We shouldn't use DESTDIR
/ set prefix to /usr for host builds. From a quick look the prefix is at
least used in libcap.pc, so other host packages will get wrong info if
they use pkgconfig to find host-libcap.
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2016-03-16 22:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 20:20 [Buildroot] [PATCH 1/4] libcap: bump version Thomas Petazzoni
2016-03-16 20:20 ` [Buildroot] [PATCH 2/4] libcap: add patch to fix build issue with old kernel headers Thomas Petazzoni
2016-03-16 22:16 ` Peter Korsgaard
2016-03-16 22:34 ` Thomas Petazzoni
2016-03-16 22:44 ` Peter Korsgaard
2016-03-17 8:20 ` Thomas Petazzoni
2016-03-16 20:20 ` [Buildroot] [PATCH 3/4] libcap, cdrkit, dvdrw-tools, fastd, squid: remove headers >= 3.0 dependency Thomas Petazzoni
2016-03-16 22:23 ` Peter Korsgaard
2016-03-16 20:20 ` [Buildroot] [PATCH 4/4] lxc: remove dependency on headers >= 3.0 Thomas Petazzoni
2016-03-16 22:31 ` Peter Korsgaard
2016-03-16 22:36 ` Thomas Petazzoni
2016-03-16 22:45 ` Peter Korsgaard
2016-03-16 22:49 ` Arnout Vandecappelle
2016-03-17 6:22 ` Peter Korsgaard
2016-03-16 22:09 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fh28483.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox