From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V2] package/systemd: Respect BR2_TARGET_GENERIC_GETTY_BAUDRATE
Date: Sun, 20 Mar 2016 23:38:23 +0100 [thread overview]
Message-ID: <20160320233823.06fa0c78@free-electrons.com> (raw)
In-Reply-To: <CAGduivzd_HebHnm54y4wbvZGvTZL6Nhwz_q4ufFT74Uf=HAPwg@mail.gmail.com>
Hello,
On Sun, 13 Mar 2016 21:28:05 +0100, Maxime Hadjinlian wrote:
> > ln -fs ../../../../lib/systemd/system/$${SERVICE}@.service \
> > - $(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service
> > + $(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
> > + if [ $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE)) -gt 0 ] ; \
> > + then \
> > + $(SED) 's,115200,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE),' $(TARGET_DIR)/lib/systemd/system/$${SERVICE}@.service; \
> > + fi
> > endef
> > endif
> >
> > --
> > 2.7.2
> >
>
> I don't think it's a problem for getty, but still worth noting
> somewhere, this will replace '115200' (without the quotes) by say
> "9600" (with the quotes) because the quotes are present in
> system/Config.in (maybe they could be removed ? There's no type for
> that sort of things in Kconfig as far as I know (which is not much) ?
I'm not sure to understand what you meant. Did you mean that he should
be calling qstrip on the variable?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-20 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 1:05 [Buildroot] [PATCH V2] package/systemd: Respect BR2_TARGET_GENERIC_GETTY_BAUDRATE Cyril Bur
2016-03-13 20:28 ` Maxime Hadjinlian
2016-03-20 22:38 ` Thomas Petazzoni [this message]
2016-03-20 22:51 ` Cyril Bur
2016-03-21 10:05 ` Maxime Hadjinlian
2016-03-31 2:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320233823.06fa0c78@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox