[Buildroot] [PATCH V2] package/systemd: Respect BR2_TARGET_GENERIC_GETTY_BAUDRATE

[Cyril Bur <cyrilbur@gmail.com>]

On Sun, 20 Mar 2016 23:38:23 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Hello,
> 
> On Sun, 13 Mar 2016 21:28:05 +0100, Maxime Hadjinlian wrote:
> 
> > >         ln -fs ../../../../lib/systemd/system/$${SERVICE}@.service \
> > > -               $(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service
> > > +               $(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
> > > +       if [ $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE)) -gt 0 ] ; \
> > > +       then \
> > > +               $(SED) 's,115200,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE),' $(TARGET_DIR)/lib/systemd/system/$${SERVICE}@.service; \
> > > +       fi
> > >  endef
> > >  endif
> > >
> > > --
> > > 2.7.2
> > >  
> > 
> > I don't think it's a problem for getty, but still worth noting
> > somewhere, this will replace '115200' (without the quotes) by say
> > "9600" (with the quotes) because the quotes are present in
> > system/Config.in (maybe they could be removed ? There's no type for
> > that sort of things in Kconfig as far as I know (which is not much) ?  
> 
> I'm not sure to understand what you meant. Did you mean that he should
> be calling qstrip on the variable?
> 

I think Maxime was just pointing out what my patch will 'add' quotes. I could
have called qstrip but (I think this was mentioned in V1) AFAIK systemd is
perfectly happy to accept quotes in service files.

If you or someone else would be more comfortable with a qstrip, I can add that.

Cyril

> Thanks,
> 
> Thomas