[Buildroot] [PATCH] package/libxslt: fix static build

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Tue, 29 Mar 2016 03:01:13 +0200, Thomas Petazzoni wrote:

> I've applied because it indeed works, but to be honest, I don't
> understand why: I don't quite understand how this can fix the build.
> All what this option does is:
> 
> AC_ARG_WITH(libxml-libs-prefix,
>         [  --with-libxml-libs-prefix=[PFX]      Specify location of libxml libs],
>         LIBXML_LIBS="-L$withval"
> )
> 
> I.e, it will add -L$(STAGING_DIR)/usr/lib to the gcc options. But that
> is completely useless because $(STAGING_DIR)/usr/lib is already the
> default search path for libraries. So why does it fix the build? I
> don't know.

Baruch has posted another patch that I believe is supposed to fix the
same problem: http://patchwork.ozlabs.org/patch/602529/.

Baruch, J?rg, could you have a closer look at this problem, and see
which solution, between the one from J?rg and the one from Baruch is
actually correct ?

I must say I remain surprised that the version proposed by J?rg
actually works, but it does. The version posted by Baruch seems more
correct to me.

However, one drawback of the solution proposed by Baruch is that even
when doing dynamic linking, the application linking against libxml2 will
be directly linking against liblzma, which is not necessary. But that's
already what happens for libz, libpthread, and the other libraries
listed in XML_LIBS, so from that point of view, Baruch solution is in
line with what libxml2 is already doing.

Ideally, xml2-config should have a --static option, or even better,
drop xml2-config entirely and use pkg-config :-)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com