Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libxslt: fix static build
Date: Tue, 29 Mar 2016 19:56:51 +0200	[thread overview]
Message-ID: <20160329195651.4d02a33f@free-electrons.com> (raw)
In-Reply-To: <20160329174453.GS2637@tarshish>

Hello,

On Tue, 29 Mar 2016 20:44:53 +0300, Baruch Siach wrote:

> On Tue, Mar 29, 2016 at 02:52:14PM +0200, Thomas Petazzoni wrote:
> > On Tue, 29 Mar 2016 03:01:13 +0200, Thomas Petazzoni wrote:
> > > I've applied because it indeed works, but to be honest, I don't
> > > understand why: I don't quite understand how this can fix the build.
> > > All what this option does is:
> > > 
> > > AC_ARG_WITH(libxml-libs-prefix,
> > >         [  --with-libxml-libs-prefix=[PFX]      Specify location of libxml libs],
> > >         LIBXML_LIBS="-L$withval"
> > > )
> > > 
> > > I.e, it will add -L$(STAGING_DIR)/usr/lib to the gcc options. But that
> > > is completely useless because $(STAGING_DIR)/usr/lib is already the
> > > default search path for libraries. So why does it fix the build? I
> > > don't know.
> > 
> > Baruch has posted another patch that I believe is supposed to fix the
> > same problem: http://patchwork.ozlabs.org/patch/602529/.
> > 
> > Baruch, J?rg, could you have a closer look at this problem, and see
> > which solution, between the one from J?rg and the one from Baruch is
> > actually correct ?
> 
> The libxml2 patch fixes a bug in xml2-config generation. It fixes static build 
> also for raptor, and possibly other libxml2 users (for which libxml2 is only 
> an optional dependency, so we don't see hard failures). So I think that the 
> libxml2 patch should be applied regardless of this one.

Could one of you check if, after the xml2 patch has been applied, the
libxslt fix from J?rg is still needed?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-03-29 17:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 21:09 [Buildroot] [PATCH] package/libxslt: fix static build Jörg Krause
2016-03-29  1:01 ` Thomas Petazzoni
2016-03-29 12:52   ` Thomas Petazzoni
2016-03-29 13:52     ` Jörg Krause
2016-03-29 14:09       ` Thomas Petazzoni
2016-03-29 17:44     ` Baruch Siach
2016-03-29 17:56       ` Thomas Petazzoni [this message]
2016-03-29 18:35         ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160329195651.4d02a33f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox