* [Buildroot] [PATCH] package/turbolua: new package
@ 2016-03-17 15:27 Marcin Niestroj
2016-04-01 2:08 ` Thomas Petazzoni
2016-04-02 21:27 ` Arnout Vandecappelle
0 siblings, 2 replies; 3+ messages in thread
From: Marcin Niestroj @ 2016-03-17 15:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
package/Config.in | 1 +
package/turbolua/Config.in | 13 +++++++++++++
package/turbolua/turbolua.hash | 2 ++
package/turbolua/turbolua.mk | 24 ++++++++++++++++++++++++
4 files changed, 40 insertions(+)
create mode 100644 package/turbolua/Config.in
create mode 100644 package/turbolua/turbolua.hash
create mode 100644 package/turbolua/turbolua.mk
diff --git a/package/Config.in b/package/Config.in
index 2401867..e722684 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -540,6 +540,7 @@ menu "Lua libraries/modules"
source "package/lzlib/Config.in"
source "package/orbit/Config.in"
source "package/rings/Config.in"
+ source "package/turbolua/Config.in"
source "package/wsapi/Config.in"
source "package/xavante/Config.in"
endmenu
diff --git a/package/turbolua/Config.in b/package/turbolua/Config.in
new file mode 100644
index 0000000..f42f4ca
--- /dev/null
+++ b/package/turbolua/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_TURBOLUA
+ bool "turbolua"
+ depends on BR2_PACKAGE_LUAJIT
+ depends on !BR2_ARM_INSTRUCTIONS_THUMB2
+ help
+ Turbo.lua is a framework built for LuaJIT 2 to simplify the task of
+ building fast and scalable network applications. It uses a
+ event-driven, non-blocking, no thread design to deliver excellent
+ performance and minimal footprint to high-load applications while
+ also providing excellent support for embedded uses. The toolkit can
+ be used for HTTP REST API?s, traditional dynamic web pages through
+ templating, open connections like WebSockets, or just as high level
+ building blocks for native speed network applications.
diff --git a/package/turbolua/turbolua.hash b/package/turbolua/turbolua.hash
new file mode 100644
index 0000000..e0a54d7
--- /dev/null
+++ b/package/turbolua/turbolua.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 5bee3132d28e56b432bd76221b4bd221666130000814a7eb5867f12b11d23b0f turbolua-v2.0.4.tar.gz
diff --git a/package/turbolua/turbolua.mk b/package/turbolua/turbolua.mk
new file mode 100644
index 0000000..ed4e0f9
--- /dev/null
+++ b/package/turbolua/turbolua.mk
@@ -0,0 +1,24 @@
+################################################################################
+#
+# turbolua
+#
+################################################################################
+
+TURBOLUA_VERSION = v2.0.4
+TURBOLUA_SITE = $(call github,kernelsauce,turbo,$(TURBOLUA_VERSION))
+TURBOLUA_DEPENDENCIES = luajit
+TURBOLUA_LICENSE = Apache-2.0
+TURBOLUA_LICENSE_FILES = LICENSE
+
+define TURBOLUA_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" \
+ LUAJIT_VERSION="$(LUAJIT_VERSION)" -C $(@D) all
+endef
+
+define TURBOLUA_INSTALL_TARGET_CMDS
+ $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" LDCONFIG=true \
+ LUAJIT_VERSION="$(LUAJIT_VERSION)" \
+ PREFIX="$(TARGET_DIR)/usr" -C $(@D) install
+endef
+
+$(eval $(generic-package))
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/turbolua: new package
2016-03-17 15:27 [Buildroot] [PATCH] package/turbolua: new package Marcin Niestroj
@ 2016-04-01 2:08 ` Thomas Petazzoni
2016-04-02 21:27 ` Arnout Vandecappelle
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-04-01 2:08 UTC (permalink / raw)
To: buildroot
Hello Marcin,
This looks really good, I only have a few minor comments/questions. In
fact, if I didn't had that question about thumb2, I would have
applied :)
On Thu, 17 Mar 2016 16:27:39 +0100, Marcin Niestroj wrote:
> diff --git a/package/turbolua/Config.in b/package/turbolua/Config.in
> new file mode 100644
> index 0000000..f42f4ca
> --- /dev/null
> +++ b/package/turbolua/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_TURBOLUA
> + bool "turbolua"
> + depends on BR2_PACKAGE_LUAJIT
> + depends on !BR2_ARM_INSTRUCTIONS_THUMB2
It would be good to add a comment above this line to explain why Thumb2
is excluded.
> + help
> + Turbo.lua is a framework built for LuaJIT 2 to simplify the task of
> + building fast and scalable network applications. It uses a
> + event-driven, non-blocking, no thread design to deliver excellent
> + performance and minimal footprint to high-load applications while
> + also providing excellent support for embedded uses. The toolkit can
> + be used for HTTP REST API?s, traditional dynamic web pages through
> + templating, open connections like WebSockets, or just as high level
> + building blocks for native speed network applications.
Please add an empty new line here, followed by the URL of the project
homepage.
> +define TURBOLUA_BUILD_CMDS
> + $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" \
Can you try to use $(TARGET_CONFIGURE_OPTS) instead of passing CC/LD ?
TARGET_CONFIGURE_OPTS will not only pass CC/LD, but also CFLAGS,
LDFLAGS and more.
> +define TURBOLUA_INSTALL_TARGET_CMDS
> + $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" LDCONFIG=true \
Same here.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/turbolua: new package
2016-03-17 15:27 [Buildroot] [PATCH] package/turbolua: new package Marcin Niestroj
2016-04-01 2:08 ` Thomas Petazzoni
@ 2016-04-02 21:27 ` Arnout Vandecappelle
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2016-04-02 21:27 UTC (permalink / raw)
To: buildroot
Hi Marcin,
In addition to Thomas's comments:
On 03/17/16 16:27, Marcin Niestroj wrote:
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
[snip]
> diff --git a/package/turbolua/Config.in b/package/turbolua/Config.in
> new file mode 100644
> index 0000000..f42f4ca
> --- /dev/null
> +++ b/package/turbolua/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_TURBOLUA
> + bool "turbolua"
> + depends on BR2_PACKAGE_LUAJIT
> + depends on !BR2_ARM_INSTRUCTIONS_THUMB2
> + help
> + Turbo.lua is a framework built for LuaJIT 2 to simplify the task of
> + building fast and scalable network applications. It uses a
> + event-driven, non-blocking, no thread design to deliver excellent
> + performance and minimal footprint to high-load applications while
> + also providing excellent support for embedded uses. The toolkit can
> + be used for HTTP REST API?s, traditional dynamic web pages through
> + templating, open connections like WebSockets, or just as high level
> + building blocks for native speed network applications.
The lines of the help text are a bit too long. It should be wrapped at 72
columns, where tab counts for 8, so 62 actual characters.
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-02 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 15:27 [Buildroot] [PATCH] package/turbolua: new package Marcin Niestroj
2016-04-01 2:08 ` Thomas Petazzoni
2016-04-02 21:27 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox