[Buildroot] [PATCH v1] qt5tools: disable qdoc (needs qtdeclarative)

[Buildroot] [PATCH v1] qt5tools: disable qdoc (needs qtdeclarative)

[Peter Seiderer]

Fixes [1]:

  Project ERROR: Unknown module(s) in QT: qmldevtools-private
  Makefile:63: recipe for target 'sub-qdoc-qmake_all' failed

[1] http://autobuild.buildroot.net/results/b0a/b0a5641beae14ff79a9d5a628bb41957826eb623

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 .../0001-Disable-qdoc-needs-qtdeclarative.patch    | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/qt5/qt5tools/0001-Disable-qdoc-needs-qtdeclarative.patch

diff --git a/package/qt5/qt5tools/0001-Disable-qdoc-needs-qtdeclarative.patch b/package/qt5/qt5tools/0001-Disable-qdoc-needs-qtdeclarative.patch
new file mode 100644
index 0000000..61cbdfe
--- /dev/null
+++ b/package/qt5/qt5tools/0001-Disable-qdoc-needs-qtdeclarative.patch
@@ -0,0 +1,30 @@
+From acdb24783322bb6e69df61cf04df2b2e47a06ad2 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Tue, 29 Mar 2016 13:37:09 +0200
+Subject: [PATCH] Disable qdoc (needs qtdeclarative).
+
+Fixes:
+
+  Project ERROR: Unknown module(s) in QT: qmldevtools-private
+  Makefile:63: recipe for target 'sub-qdoc-qmake_all' failed
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ src/src.pro | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/src/src.pro b/src/src.pro
+index 387d54f..494898f 100644
+--- a/src/src.pro
++++ b/src/src.pro
+@@ -14,7 +14,6 @@ qtHaveModule(widgets) {
+ }
+ 
+ SUBDIRS += linguist \
+-    qdoc \
+     qtplugininfo
+ if(!android|android_app):!ios: SUBDIRS += qtpaths
+ 
+-- 
+2.1.4
+
-- 
2.1.4

[Buildroot] [PATCH v1] qt5tools: disable qdoc (needs qtdeclarative)

[Thomas Petazzoni]

Hello,

On Tue, 29 Mar 2016 13:45:25 +0200, Peter Seiderer wrote:
> Fixes [1]:
> 
>   Project ERROR: Unknown module(s) in QT: qmldevtools-private
>   Makefile:63: recipe for target 'sub-qdoc-qmake_all' failed
> 
> [1] http://autobuild.buildroot.net/results/b0a/b0a5641beae14ff79a9d5a628bb41957826eb623
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Thanks, I've applied to fix the build issue, but I would really prefer
a solution that is acceptable upstream. If I remember correctly, you
can do some conditionals in .pro files like "if qtdeclarative is
available, then do this". This way, you could build qdoc if
qtdeclarative is available, and not build it otherwise.

What do you think?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v1] qt5tools: disable qdoc (needs qtdeclarative)

[Peter Seiderer]

Hello Thomas,

On Tue, 29 Mar 2016 14:55:43 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Hello,
> 
> On Tue, 29 Mar 2016 13:45:25 +0200, Peter Seiderer wrote:
> > Fixes [1]:
> > 
> >   Project ERROR: Unknown module(s) in QT: qmldevtools-private
> >   Makefile:63: recipe for target 'sub-qdoc-qmake_all' failed
> > 
> > [1] http://autobuild.buildroot.net/results/b0a/b0a5641beae14ff79a9d5a628bb41957826eb623
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> 
> Thanks, I've applied to fix the build issue, but I would really prefer
> a solution that is acceptable upstream. If I remember correctly, you
> can do some conditionals in .pro files like "if qtdeclarative is
> available, then do this". This way, you could build qdoc if
> qtdeclarative is available, and not build it otherwise.
> 
> What do you think?

Will try to submit the conditional compile solution upstream (but not sure
if the preferred upstream solution would be qdoc without qml support as done
for the linguist/lupdate tool)...

Regards,
Peter

> 
> Thomas

[Buildroot] [PATCH v1] qt5tools: disable qdoc (needs qtdeclarative)

[Peter Seiderer]

Hello Thomas,

On Tue, 29 Mar 2016 15:51:01 +0200, Peter Seiderer <ps.report@gmx.net> wrote:

> Hello Thomas,
> 
> On Tue, 29 Mar 2016 14:55:43 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> 
> > Hello,
> > 
> > On Tue, 29 Mar 2016 13:45:25 +0200, Peter Seiderer wrote:
> > > Fixes [1]:
> > > 
> > >   Project ERROR: Unknown module(s) in QT: qmldevtools-private
> > >   Makefile:63: recipe for target 'sub-qdoc-qmake_all' failed
> > > 
> > > [1] http://autobuild.buildroot.net/results/b0a/b0a5641beae14ff79a9d5a628bb41957826eb623
> > > 
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > 
> > Thanks, I've applied to fix the build issue, but I would really prefer
> > a solution that is acceptable upstream. If I remember correctly, you
> > can do some conditionals in .pro files like "if qtdeclarative is
> > available, then do this". This way, you could build qdoc if
> > qtdeclarative is available, and not build it otherwise.
> > 
> > What do you think?
> 
> Will try to submit the conditional compile solution upstream (but not sure
> if the preferred upstream solution would be qdoc without qml support as done
> for the linguist/lupdate tool)...
> 

No (more) need for a upstream patch, the proper solution will be in
the next qttools release: commit 'qdoc: Let qdoc run without QtDeclarative'
from Martin Smith (see [1] and [2])...

Regards,
Peter
 
[1] https://bugreports.qt.io/browse/QTBUG-51676
[2] http://code.qt.io/cgit/qt/qttools.git/commit/?id=2b262fad86ef38a5fa692b4c73e6ec26a5d45a5f


> Regards,
> Peter
> 
> > 
> > Thomas
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot