Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] qt5connectivity: add QtNfc submodule
Date: Tue, 19 Apr 2016 00:01:52 +0200	[thread overview]
Message-ID: <20160419000152.7bae41fc@free-electrons.com> (raw)
In-Reply-To: <20160413235317.604bbd46@free-electrons.com>

Hello,

On Wed, 13 Apr 2016 23:53:17 +0200, Thomas Petazzoni wrote:

> So until now, neard was not necessary, and without any version bump or
> anything, it should become a mandatory dependency? This seems weird,
> and does not quite follow the policy of Buildroot that we should have
> as much as possible the smallest set of mandatory dependencies.

I just tested, and indeed you can build Qt5Connectivity without
Bluetooth support and have only NFC support. Or build only Bluetooth
support without NFC support.

So could you make these optional?

I'll mark your patch as Changes Requested in patchwork in the mean time.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-18 22:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04  9:56 [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth Julien Corjon
2016-04-04  9:56 ` [Buildroot] [PATCH 2/2] qt5connectivity: add QtNfc submodule Julien Corjon
2016-04-04 20:13   ` Arnout Vandecappelle
2016-04-13 21:53   ` Thomas Petazzoni
2016-04-18 22:01     ` Thomas Petazzoni [this message]
2016-04-19 11:43   ` [Buildroot] [PATCH v2 1/2] " Julien Corjon
2016-04-19 11:43     ` [Buildroot] [PATCH v2 2/2] qt5connectivity: add bluez5_utils option for QtBluetooth submodule Julien Corjon
2016-06-03 17:52       ` Thomas Petazzoni
2016-06-03 17:51     ` [Buildroot] [PATCH v2 1/2] qt5connectivity: add QtNfc submodule Thomas Petazzoni
2016-04-04 10:02 ` [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth Yegor Yefremov
2016-04-04 20:26   ` Arnout Vandecappelle
2016-04-05 14:25     ` Thomas Petazzoni
2016-04-18 22:10     ` Thomas Petazzoni
2016-04-19 10:53       ` Julien CORJON
2016-04-19 11:26         ` Thomas Petazzoni
2016-04-13 21:50 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160419000152.7bae41fc@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox