From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth
Date: Mon, 4 Apr 2016 22:26:12 +0200 [thread overview]
Message-ID: <5702CDE4.1080703@mind.be> (raw)
In-Reply-To: <CAGm1_ktt4d7ELbUUuEyPX6qiEvXbBdOGhkiC4+yu_s3K6VP4kw@mail.gmail.com>
On 04/04/16 12:02, Yegor Yefremov wrote:
> Hi Julien, all,
>
> On Mon, Apr 4, 2016 at 11:56 AM, Julien Corjon <corjon.j@ecagroup.com> wrote:
>> Signed-off-by: Julien Corjon <corjon.j@ecagroup.com>
>> ---
>> package/qt5/qt5connectivity/qt5connectivity.mk | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/package/qt5/qt5connectivity/qt5connectivity.mk b/package/qt5/qt5connectivity/qt5connectivity.mk
>> index a68f5ec..936bc6f 100644
>> --- a/package/qt5/qt5connectivity/qt5connectivity.mk
>> +++ b/package/qt5/qt5connectivity/qt5connectivity.mk
>> @@ -43,6 +43,7 @@ endif
>>
>> define QT5CONNECTIVITY_INSTALL_TARGET_CMDS
>> cp -dpf $(STAGING_DIR)/usr/lib/libQt5Bluetooth.so.* $(TARGET_DIR)/usr/lib
>> + cp -dpf $(STAGING_DIR)/usr/bin/sdpscanner $(TARGET_DIR)/usr/bin
>
> would $(INSTALL) be preferable here? Do we have any rules?
We generally prefer install, but in this case it's nice to keep the same
construct as the previous line, so I'm OK with it. So:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
That said, I wonder why we are doing all this manual copying for qt5, instead
of just running 'make install'. AFAICS the only thing that isn't already cleaned
up in the finalize step are the QML files, and these can easily be cleaned up as
a finalize hook. Thomas, do you remember why you did it this way?
Regards,
Arnout
>
> Yegor
>
>> $(QT5CONNECTIVITY_INSTALL_TARGET_QMLS)
>> endef
>>
>> --
>> 2.5.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-04-04 20:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 9:56 [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth Julien Corjon
2016-04-04 9:56 ` [Buildroot] [PATCH 2/2] qt5connectivity: add QtNfc submodule Julien Corjon
2016-04-04 20:13 ` Arnout Vandecappelle
2016-04-13 21:53 ` Thomas Petazzoni
2016-04-18 22:01 ` Thomas Petazzoni
2016-04-19 11:43 ` [Buildroot] [PATCH v2 1/2] " Julien Corjon
2016-04-19 11:43 ` [Buildroot] [PATCH v2 2/2] qt5connectivity: add bluez5_utils option for QtBluetooth submodule Julien Corjon
2016-06-03 17:52 ` Thomas Petazzoni
2016-06-03 17:51 ` [Buildroot] [PATCH v2 1/2] qt5connectivity: add QtNfc submodule Thomas Petazzoni
2016-04-04 10:02 ` [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth Yegor Yefremov
2016-04-04 20:26 ` Arnout Vandecappelle [this message]
2016-04-05 14:25 ` Thomas Petazzoni
2016-04-18 22:10 ` Thomas Petazzoni
2016-04-19 10:53 ` Julien CORJON
2016-04-19 11:26 ` Thomas Petazzoni
2016-04-13 21:50 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702CDE4.1080703@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox