From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] linux-headers: rename _AS_KERNEL to _FROM_KERNEL
Date: Tue, 19 Apr 2016 23:13:58 +0200 [thread overview]
Message-ID: <20160419231358.61e8f0c6@free-electrons.com> (raw)
In-Reply-To: <1461099155-30702-4-git-send-email-vivien.didelot@savoirfairelinux.com>
Hello,
On Tue, 19 Apr 2016 16:52:34 -0400, Vivien Didelot wrote:
> BR2_KERNEL_HEADERS_AS_KERNEL is confusing when making the choice between
> downloading the headers from an independent kernel source, and using the
> headers found in the kernel built by Buildroot.
>
> Rename it to BR2_KERNEL_HEADERS_FROM_KERNEL.
>
> In the meantime, document this distinction between the two choices.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
I tend to disagree here. The headers are not "from" the kernel, since
in practice, we download the kernel source code twice and extract it
twice. So the "as kernel" really seem better. It could be "like kernel"
as well, but "from kernel" seems wrong.
However, I'm all for improving the help texts to make this clearer.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-19 21:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 20:52 [Buildroot] [PATCH 0/4] match headers with latest kernel source Vivien Didelot
2016-04-19 20:52 ` [Buildroot] [PATCH 1/4] linux: explicit latest kernel version Vivien Didelot
2016-04-19 22:54 ` Arnout Vandecappelle
2016-04-20 15:39 ` Thomas Petazzoni
2016-04-19 20:52 ` [Buildroot] [PATCH 2/4] linux-headers: indent custom choices Vivien Didelot
2016-04-19 22:58 ` Arnout Vandecappelle
2016-04-20 7:01 ` Thomas Petazzoni
2016-04-20 13:52 ` Vivien Didelot
2016-07-01 14:22 ` Yann E. MORIN
2016-04-19 20:52 ` [Buildroot] [PATCH 3/4] linux-headers: rename _AS_KERNEL to _FROM_KERNEL Vivien Didelot
2016-04-19 21:13 ` Thomas Petazzoni [this message]
2016-04-19 22:12 ` Vivien Didelot
2016-07-01 14:34 ` Yann E. MORIN
2016-07-01 17:51 ` Steve Calfee
2016-07-01 17:56 ` Yann E. MORIN
2016-04-19 20:52 ` [Buildroot] [PATCH 4/4] linux-headers: match headers for the latest kernel Vivien Didelot
2016-07-01 16:06 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419231358.61e8f0c6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox