From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] linux-headers: indent custom choices
Date: Wed, 20 Apr 2016 09:01:03 +0200 [thread overview]
Message-ID: <20160420090103.6bb2c824@free-electrons.com> (raw)
In-Reply-To: <5716B828.2070008@mind.be>
Hello,
On Wed, 20 Apr 2016 00:58:48 +0200, Arnout Vandecappelle wrote:
> We currently have 5 choice statements where the contents is indented, and 54
> where it's not. So I wouldn't say that we usually indent it...
I agreed.
> That said, I'm not strictly against indenting choice contents: it's not going
> to be nested any deeper, and the lines are normally not that long. The only
> question is what to do with the help texts, because they would suddenly have to
> be wrapped at 82 characters...
I prefer to keep things non-indented. Otherwise, to be consistent, we
would also have to indent the config options within a if...endif block,
or within a menuconfig...endmenu. And then suddenly you can have a
choice nested in an if, nested in a menuconfig, and your indentation
goes crazy.
So, I'd say no.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-20 7:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 20:52 [Buildroot] [PATCH 0/4] match headers with latest kernel source Vivien Didelot
2016-04-19 20:52 ` [Buildroot] [PATCH 1/4] linux: explicit latest kernel version Vivien Didelot
2016-04-19 22:54 ` Arnout Vandecappelle
2016-04-20 15:39 ` Thomas Petazzoni
2016-04-19 20:52 ` [Buildroot] [PATCH 2/4] linux-headers: indent custom choices Vivien Didelot
2016-04-19 22:58 ` Arnout Vandecappelle
2016-04-20 7:01 ` Thomas Petazzoni [this message]
2016-04-20 13:52 ` Vivien Didelot
2016-07-01 14:22 ` Yann E. MORIN
2016-04-19 20:52 ` [Buildroot] [PATCH 3/4] linux-headers: rename _AS_KERNEL to _FROM_KERNEL Vivien Didelot
2016-04-19 21:13 ` Thomas Petazzoni
2016-04-19 22:12 ` Vivien Didelot
2016-07-01 14:34 ` Yann E. MORIN
2016-07-01 17:51 ` Steve Calfee
2016-07-01 17:56 ` Yann E. MORIN
2016-04-19 20:52 ` [Buildroot] [PATCH 4/4] linux-headers: match headers for the latest kernel Vivien Didelot
2016-07-01 16:06 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420090103.6bb2c824@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox