Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cam Hutchison <camh@xdna.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
Date: Fri, 22 Apr 2016 11:09:50 +1000	[thread overview]
Message-ID: <20160422010950.GA28839@xdna.net> (raw)
In-Reply-To: <20160420230245.2e5629d4@free-electrons.com>

Hi Thomas,

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

>On Mon, 04 Apr 2016 19:31:49 +0000, Geoff Levand wrote:
>> Add a new package go-bootstrap which builds a bootstrap compiler for the
>> go programming language.
>> 

>I've applied to master after doing the following changes:

>    [Thomas:
>     - Rename GO_BOOTSTRAP_FINAL to HOST_GO_BOOTSTRAP_ROOT. Use the HOST_
>       prefix because this variable is specific to the host variant. And
>       it's not "final" at all, but rather the "root" of the Go Bootstrap
>       installation.
>     - Rename GO_BOOTSTRAP_MAKE_ENV to HOST_GO_BOOTSTRAP_MAKE_ENV, also to
>       have the HOST_ prefix because it's a host package.]

I just started playing with these patches a few days ago and made a local
change to this patch that made sense to me - I removed the
HOST_GO_BOOTSTRAP_INSTALL_CMDS because I did not see that it was useful
to have the bootstrap compiler installed in the HOST_DIR. This mattered
for me as I build the toolchain and install it system-wide to use for
other builds, which refer to that toolchain as an external one.

I then changed the second patch to use HOST_GO_BOOTSTRAP_BUILDDIR
instead of GO_BOOTSTRAP_FINAL.

Does this make sense to have in buildroot?

  reply	other threads:[~2016-04-22  1:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
2016-04-04 19:31 ` [Buildroot] [PATCH v3 2/3] go: new host package Geoff Levand
2016-04-20 21:03   ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 3/3] flannel: new package Geoff Levand
2016-04-20 21:03   ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package Geoff Levand
2016-04-20 21:02   ` Thomas Petazzoni
2016-04-22  1:09     ` Cam Hutchison [this message]
2016-04-22  9:51       ` Thomas Petazzoni
2016-04-22 21:41         ` Cam Hutchison
2016-04-22 21:49           ` Thomas Petazzoni
2016-04-23  8:34             ` Peter Korsgaard
2016-04-06  5:05 ` [Buildroot] [PATCH v3 0/3] Add go language support Christian Stewart
2016-04-06 16:23   ` Geoff Levand
2016-04-21 20:43 ` Thomas Petazzoni
2016-04-25 16:27   ` Geoff Levand
2016-04-29 21:26   ` Geoff Levand
2016-04-30 12:03     ` Thomas Petazzoni
2016-05-01  3:43       ` Christian Stewart
2016-05-02 16:37         ` Geoff Levand
2016-05-03  7:08           ` Thomas Petazzoni
2016-05-06 19:57             ` Geoff Levand
2016-05-06 19:58               ` Geoff Levand
2016-05-07 23:48                 ` Arnout Vandecappelle
2016-05-02 16:21       ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160422010950.GA28839@xdna.net \
    --to=camh@xdna.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox