Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
Date: Fri, 22 Apr 2016 11:51:29 +0200	[thread overview]
Message-ID: <20160422115129.4c4b523b@free-electrons.com> (raw)
In-Reply-To: <20160422010950.GA28839@xdna.net>

Hello,

On Fri, 22 Apr 2016 11:09:50 +1000, Cam Hutchison wrote:

> I just started playing with these patches a few days ago and made a local
> change to this patch that made sense to me - I removed the
> HOST_GO_BOOTSTRAP_INSTALL_CMDS because I did not see that it was useful
> to have the bootstrap compiler installed in the HOST_DIR. This mattered
> for me as I build the toolchain and install it system-wide to use for
> other builds, which refer to that toolchain as an external one.
> 
> I then changed the second patch to use HOST_GO_BOOTSTRAP_BUILDDIR
> instead of GO_BOOTSTRAP_FINAL.
> 
> Does this make sense to have in buildroot?

We normally try to not use things from the build directory of package A
when building package B. In an ideal world, things should be
implemented as if we could remove the build directory of a package once
it has been installed in the host/staging/target directories. It should
therefore install there everything that might be needed by packages
that depend on that package.

That being said:

 1/ There are already numerous exceptions to this rule. For example,
    all the external kernel modules directly refer to $(LINUX_DIR). And
    I guess there are other cases as well.

 2/ The host-go-bootstrap case is also somewhat special.

Let's see what Arnout/Peter/Yann think about this, whether we really
need to enforce this rule or not.

However, back to your original problem, I don't really see why the fact
that host-go-bootstrap is installed in $(HOST_DIR) prevents you from
installing the toolchain system-wide for use by other builds. Yes, it
increases the size of the host directory, but other than that I don't
see the technical limitation.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-22  9:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
2016-04-04 19:31 ` [Buildroot] [PATCH v3 3/3] flannel: new package Geoff Levand
2016-04-20 21:03   ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 2/3] go: new host package Geoff Levand
2016-04-20 21:03   ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 1/3] go-bootstrap: " Geoff Levand
2016-04-20 21:02   ` Thomas Petazzoni
2016-04-22  1:09     ` Cam Hutchison
2016-04-22  9:51       ` Thomas Petazzoni [this message]
2016-04-22 21:41         ` Cam Hutchison
2016-04-22 21:49           ` Thomas Petazzoni
2016-04-23  8:34             ` Peter Korsgaard
2016-04-06  5:05 ` [Buildroot] [PATCH v3 0/3] Add go language support Christian Stewart
2016-04-06 16:23   ` Geoff Levand
2016-04-21 20:43 ` Thomas Petazzoni
2016-04-25 16:27   ` Geoff Levand
2016-04-29 21:26   ` Geoff Levand
2016-04-30 12:03     ` Thomas Petazzoni
2016-05-01  3:43       ` Christian Stewart
2016-05-02 16:37         ` Geoff Levand
2016-05-03  7:08           ` Thomas Petazzoni
2016-05-06 19:57             ` Geoff Levand
2016-05-06 19:58               ` Geoff Levand
2016-05-07 23:48                 ` Arnout Vandecappelle
2016-05-02 16:21       ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160422115129.4c4b523b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox