* [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages
@ 2016-04-23 20:59 Bernd Kuhls
2016-04-23 20:59 ` [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license Bernd Kuhls
2016-04-24 8:23 ` [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-04-23 20:59 UTC (permalink / raw)
To: buildroot
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/freeswitch/freeswitch.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk
index f25b9fa..ec52172 100644
--- a/package/freeswitch/freeswitch.mk
+++ b/package/freeswitch/freeswitch.mk
@@ -153,6 +153,8 @@ define FREESWITCH_ENABLE_MODULES
$(Q)echo $(FREESWITCH_ENABLED_MODULES) \
| tr ' ' '\n' \
> $(@D)/modules.conf
+ > $(@D)/noreg
+ > $(@D)/cluecon2.tmpl
endef
FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license
2016-04-23 20:59 [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Bernd Kuhls
@ 2016-04-23 20:59 ` Bernd Kuhls
2016-04-24 8:20 ` Thomas Petazzoni
2016-05-09 20:02 ` Thomas Petazzoni
2016-04-24 8:23 ` [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Thomas Petazzoni
1 sibling, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-04-23 20:59 UTC (permalink / raw)
To: buildroot
Noted by Thomas:
http://lists.busybox.net/pipermail/buildroot/2016-April/158864.html
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/freeswitch/freeswitch.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk
index ec52172..f76ad24 100644
--- a/package/freeswitch/freeswitch.mk
+++ b/package/freeswitch/freeswitch.mk
@@ -161,7 +161,7 @@ FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES
# mod_isac supports a limited set of archs
# src/mod/codecs/mod_isac/typedefs.h
ifeq ($(BR2_i386)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_x86_64),y)
-FREESWITCH_LICENSE += BSD-3c (mod_isac)
+FREESWITCH_LICENSE := $(FREESWITCH_LICENSE) BSD-3c (mod_isac)
FREESWITCH_LICENSE_FILES += src/mod/codecs/mod_isac/LICENSE
FREESWITCH_ENABLED_MODULES += codecs/mod_isac
endif
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license
2016-04-23 20:59 ` [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license Bernd Kuhls
@ 2016-04-24 8:20 ` Thomas Petazzoni
2016-05-09 20:02 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-04-24 8:20 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 23 Apr 2016 22:59:49 +0200, Bernd Kuhls wrote:
> diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk
> index ec52172..f76ad24 100644
> --- a/package/freeswitch/freeswitch.mk
> +++ b/package/freeswitch/freeswitch.mk
> @@ -161,7 +161,7 @@ FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES
> # mod_isac supports a limited set of archs
> # src/mod/codecs/mod_isac/typedefs.h
> ifeq ($(BR2_i386)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_x86_64),y)
> -FREESWITCH_LICENSE += BSD-3c (mod_isac)
> +FREESWITCH_LICENSE := $(FREESWITCH_LICENSE) BSD-3c (mod_isac)
Hum, licenses should be comma separated, so don't we need:
FREESWITCH_LICENSE := $(FREESWITCH_LICENSE), BSD-3c (mod_isac)
?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages
2016-04-23 20:59 [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Bernd Kuhls
2016-04-23 20:59 ` [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license Bernd Kuhls
@ 2016-04-24 8:23 ` Thomas Petazzoni
2016-05-01 20:50 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-04-24 8:23 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 23 Apr 2016 22:59:48 +0200, Bernd Kuhls wrote:
> diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk
> index f25b9fa..ec52172 100644
> --- a/package/freeswitch/freeswitch.mk
> +++ b/package/freeswitch/freeswitch.mk
> @@ -153,6 +153,8 @@ define FREESWITCH_ENABLE_MODULES
> $(Q)echo $(FREESWITCH_ENABLED_MODULES) \
> | tr ' ' '\n' \
> > $(@D)/modules.conf
> + > $(@D)/noreg
> + > $(@D)/cluecon2.tmpl
Doesn't this deserve a separate pre-configure hook? Doing this hidden
in the FREESWITCH_ENABLE_MODULES hook, with no comment or explanation
whatsoever looks a bit weird.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages
2016-04-24 8:23 ` [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Thomas Petazzoni
@ 2016-05-01 20:50 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-05-01 20:50 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 24 Apr 2016 10:23:14 +0200, Thomas Petazzoni wrote:
> Doesn't this deserve a separate pre-configure hook? Doing this hidden
> in the FREESWITCH_ENABLE_MODULES hook, with no comment or explanation
> whatsoever looks a bit weird.
I've had no feedback, I'm marking this patch as Changes Requested in
patchwork. Please resend with a separate hook, or a better explanation.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license
2016-04-23 20:59 ` [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license Bernd Kuhls
2016-04-24 8:20 ` Thomas Petazzoni
@ 2016-05-09 20:02 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-05-09 20:02 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 23 Apr 2016 22:59:49 +0200, Bernd Kuhls wrote:
> Noted by Thomas:
> http://lists.busybox.net/pipermail/buildroot/2016-April/158864.html
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/freeswitch/freeswitch.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master after fixing the code so that licenses are comma
separated.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-09 20:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-23 20:59 [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Bernd Kuhls
2016-04-23 20:59 ` [Buildroot] [PATCH 2/2] package/freeswitch: Fix added license Bernd Kuhls
2016-04-24 8:20 ` Thomas Petazzoni
2016-05-09 20:02 ` Thomas Petazzoni
2016-04-24 8:23 ` [Buildroot] [PATCH 1/2] package/freeswitch: disable ClueCon invitation messages Thomas Petazzoni
2016-05-01 20:50 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox