Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: use $(LINUX_INSTALL_IMAGE_CMDS) instead of plain 'cp'
Date: Mon, 25 Apr 2016 14:13:13 +0200	[thread overview]
Message-ID: <20160425141313.4d43654c@free-electrons.com> (raw)
In-Reply-To: <20160425140615.11e86412@free-electrons.com>

Hello,

On Mon, 25 Apr 2016 14:06:15 +0200, Thomas Petazzoni wrote:

> > -	cp $(KERNEL_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME).* $(1)
> > +	cp -v $(KERNEL_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME).* $(1)
> 
> I think you did this change for debugging (which is OK), but it should
> be kept in your patch.

Obviously: it should be *removed* from your patch. Sorry for the
mess :-/

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-25 12:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 11:58 [Buildroot] [PATCH] linux: use $(LINUX_INSTALL_IMAGE_CMDS) instead of plain 'cp' Sebastian Frias
2016-04-25 12:06 ` Thomas Petazzoni
2016-04-25 12:13   ` Thomas Petazzoni [this message]
2016-04-25 12:17   ` Sebastian Frias
2016-04-25 12:23     ` Thomas Petazzoni
2016-04-25 12:44       ` Sebastian Frias
2016-04-25 14:52   ` [Buildroot] [PATCH v2] " Sebastian Frias
2016-04-25 19:43     ` Thomas Petazzoni
2016-04-26  8:44       ` Sebastian Frias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425141313.4d43654c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox