From: Sebastian Frias <sf84@laposte.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] linux: use $(LINUX_INSTALL_IMAGE_CMDS) instead of plain 'cp'
Date: Tue, 26 Apr 2016 10:44:20 +0200 [thread overview]
Message-ID: <571F2A64.3000202@laposte.net> (raw)
In-Reply-To: <20160425214332.58a41bd0@free-electrons.com>
Hi Thomas,
On 04/25/2016 09:43 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 25 Apr 2016 16:52:17 +0200, Sebastian Frias wrote:
>> The target "$(LINUX_DIR)/.stamp_initramfs_rebuilt" uses its own
>> 'cp' command, instead of LINUX_INSTALL_IMAGE/LINUX_INSTALL_IMAGES_CMDS
>> provided by (or updated with) commit 055e6162bba7 ("linux: don't build
>> appended DTB image in place and support multiple images") and thus is
>> not operating properly when APPENDED_DTB is used.
>>
>> Indeed, it copies a single image, and does not copy the one with the DTB
>> appended.
>>
>> This patch replaces the 'cp' command with LINUX_INSTALL_IMAGE which
>> handles APPENDED_DTB.
>>
>> Fixes: 055e6162bba7 ("linux: don't build appended DTB image in place and
>> support multiple images")
>>
>> Signed-off-by: Sebastian Frias <sf84@laposte.net>
>> ---
>> Changes v1 -> v2:
>> - remove '-v' from cp (as suggested by thomas.petazzoni at free-electrons.com)
>> - use LINUX_INSTALL_IMAGE instead of LINUX_INSTALL_IMAGES_CMDS (also suggested by thomas.petazzoni at free-electrons.com)
>> ---
>> linux/linux.mk | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> The commit title was no longer matching what the commit was doing, so
> I've tweaked it, and applied your patch. Thanks!
>
Oh, sorry about that (I had edited the patch manually), and thanks for fixing it! :-)
Best regards,
Sebastian
prev parent reply other threads:[~2016-04-26 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 11:58 [Buildroot] [PATCH] linux: use $(LINUX_INSTALL_IMAGE_CMDS) instead of plain 'cp' Sebastian Frias
2016-04-25 12:06 ` Thomas Petazzoni
2016-04-25 12:13 ` Thomas Petazzoni
2016-04-25 12:17 ` Sebastian Frias
2016-04-25 12:23 ` Thomas Petazzoni
2016-04-25 12:44 ` Sebastian Frias
2016-04-25 14:52 ` [Buildroot] [PATCH v2] " Sebastian Frias
2016-04-25 19:43 ` Thomas Petazzoni
2016-04-26 8:44 ` Sebastian Frias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571F2A64.3000202@laposte.net \
--to=sf84@laposte.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox